Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] formatStreams.size parameter wrong in API response, always returns 16:9 #4131

Closed
iGerman00 opened this issue Sep 29, 2023 · 1 comment · Fixed by #4586
Closed

[Bug] formatStreams.size parameter wrong in API response, always returns 16:9 #4131

iGerman00 opened this issue Sep 29, 2023 · 1 comment · Fixed by #4586
Labels
bug Something isn't working

Comments

@iGerman00
Copy link

Describe the bug
The API response for a Shorts video isn't correct. The resolution (formatStreams.size) parameter is returning 1280x720 or otherwise 16:9, while the video is clearly 9:16.

The correct resolution is shown by tools like youtube-dl (screenshot attached).

Steps to Reproduce

Logs
N/A

Screenshots
WindowsTerminal (2023-09-29 20։12։55)

Additional context
Multiple instances tested, all seemingly have this error
@iGerman00 iGerman00 added the bug Something isn't working label Sep 29, 2023
@absidue
Copy link
Contributor

absidue commented Sep 29, 2023

It's hardcoded in the code based on the itag, that part was probably written before shorts existed. Will probably be fixed by #3620.

@absidue absidue mentioned this issue Apr 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

API: Return actual stream height, width and fps absidue/invidious
2 participants
@iGerman00 @absidue