Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Title - set document title on Why Us page #21

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Document Title - set document title on Why Us page #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
44529f5
gitignore .idea
timbo-92 May 31, 2024
3106545
cli-analytics false
timbo-92 May 31, 2024
2e74213
Change document title only on Why Us page
timbo-92 May 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
~$*.pptx
node_modules
.idea
3 changes: 3 additions & 0 deletions itenium-socks/angular.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,5 +100,8 @@
}
}
}
},
"cli": {
"analytics": false
}
}
7 changes: 6 additions & 1 deletion itenium-socks/src/app/pages/why-us.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,15 @@
import { Component } from '@angular/core';
import { RouterLink } from '@angular/router';
import {Title} from "@angular/platform-browser";

@Component({
selector: 'app-why-us',
standalone: true,
imports: [RouterLink],
templateUrl: './why-us.component.html'
})
export class WhyUsComponent {}
export class WhyUsComponent {
constructor(private titleService: Title) {
this.titleService.setTitle("Why Us | Toe-tally Amazing");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

Enige probleem is nu... Als je ooit op de "Why Us" page kwam, dan blijft de title eeuwig dat!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Geimplementeerd zoals beschreven in de acceptatiecriteria!
Indien ze effectief enkel op de Why Us pagina die titel willen en elders de originele is er deze MR: #31

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hahaha!
Of de analysts / testers er zo ook over gaan denken... 😀

}
}