Document Title - set document title on Why Us page #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Laoujin
reviewed
May 31, 2024
| export class WhyUsComponent {} | ||
| export class WhyUsComponent { | ||
| constructor(private titleService: Title) { | ||
| this.titleService.setTitle("Why Us | Toe-tally Amazing"); |
There was a problem hiding this comment.
Yes!
Enige probleem is nu... Als je ooit op de "Why Us" page kwam, dan blijft de title eeuwig dat!
There was a problem hiding this comment.
Geimplementeerd zoals beschreven in de acceptatiecriteria!
Indien ze effectief enkel op de Why Us pagina die titel willen en elders de originele is er deze MR: #31
There was a problem hiding this comment.
Hahaha!
Of de analysts / testers er zo ook over gaan denken... 😀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.