Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zammad-ldap-sync secret #80

Merged
merged 7 commits into from
Jan 29, 2025
Merged

Add zammad-ldap-sync secret #80

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fc9e161
Add zammad-ldap-sync secret
sfi2022 Jan 24, 2025
f504cb2
Encode content with base64
sfi2022 Jan 24, 2025
6d91294
Move configuration values to cicd config.
sfi2022 Jan 27, 2025
4310802
Move configuration values to cicd config.
sfi2022 Jan 27, 2025
deaa7b7
Merge branch 'zammad-ldap-sync_create-secret_mpdz2-564' of https://gi…
sfi2022 Jan 27, 2025
10615ab
Comment values token, email user + password as base64 encoded.
sfi2022 Jan 27, 2025
cc15ad3
Encoding base64 by helm on-the-fly.
sfi2022 Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/zammad-ldap-sync/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v2
name: zammad-ldap-sync
version: 0.5.1
version: 0.6.0
maintainers:
- name: klml
email: [email protected]
Expand Down
9 changes: 9 additions & 0 deletions charts/zammad-ldap-sync/templates/secret.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
apiVersion: v1
kind: Secret
metadata:
name: zammad-ldap-sync
type: Opaque
data:
spring.mail.password: UmVwbGFjZVdpdGhNYWlsQWNjb3VudFBhc3N3b3JkCg==
spring.mail.username: UmVwbGFjZVdpdGhNYWlsQWNjb3VudFVzZXJuYW1lCg==
zammad.token: UmVwbGFjZVdpdGhaYW1tYWRBY2Nlc3NUb2tlbgo=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove values and add add {{ .Values.ldapSync.zammadsecret }}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really necessary ?
I think we just want to create a secret and not store any sensitive data in the configuration data.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets create the secret in helm values, so we can populate with CICD

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

Loading