Add zammad-ldap-sync secret #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfi2022
requested review from
FabianWilms
and removed request for
FabianWilms
klml
reviewed
Jan 24, 2025
| data: | ||
| spring.mail.password: UmVwbGFjZVdpdGhNYWlsQWNjb3VudFBhc3N3b3JkCg== | ||
| spring.mail.username: UmVwbGFjZVdpdGhNYWlsQWNjb3VudFVzZXJuYW1lCg== | ||
| zammad.token: UmVwbGFjZVdpdGhaYW1tYWRBY2Nlc3NUb2tlbgo= |
There was a problem hiding this comment.
please remove values and add add {{ .Values.ldapSync.zammadsecret }}
There was a problem hiding this comment.
Is this really necessary ?
I think we just want to create a secret and not store any sensitive data in the configuration data.
There was a problem hiding this comment.
lets create the secret in helm values, so we can populate with CICD
…thub.com/it-at-m/helm-charts into zammad-ldap-sync_create-secret_mpdz2-564
klml
reviewed
Jan 27, 2025
charts/zammad-ldap-sync/values.yaml
Outdated
| @@ -19,8 +20,8 @@ ldapSync: | |||
| mail: | |||
| host: mail.example.com | |||
| port: 1 | |||
| username: email-user | |||
| password: email-password | |||
| username: ZW1haWwtdXNlcgo= | |||
There was a problem hiding this comment.
please add a comment, that you have to base64 this values
klml
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Secret template added.
Reference
Issues #XXX