Bump master to next version

[howardjohn]

Move #15555 to my fork

[craigbox]

/test doc.test.multicluster

[craigbox]

needs update to https://istio.io/latest/blog/2019/introducing-istio-operator/ (if not more things that refer to the install doc for the operator)

It might be best to leave those files in and we can address them in a follow up PR?

[craigbox]

/retest for funsies

[istio-testing]

@craigbox: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

• /test doc.test.dualstack
• /test doc.test.multicluster
• /test doc.test.profile-ambient
• /test doc.test.profile-default
• /test doc.test.profile-demo
• /test doc.test.profile-minimal
• /test doc.test.profile-none
• /test gencheck
• /test lint

The following commands are available to trigger optional jobs:

• /test update-ref-docs-dry-run

Use /test all to run all jobs.

In response to this:

/retest for funsies

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[craigbox]

sigh, I was only being silly.

/retest
for realsies.

[craigbox]

default: gateway API failure due to this fixed; now just authz-tcp flake
multicluster: Helm has failed to deploy an egress gateway? This merits debugging I have not found out how to do locally. Perhaps I could have three instances of kind?
none: webhooks aren't being deleted when revisions are removed: istio/istio#36905

At least one test works around that like this

kubectl get validatingwebhookconfiguration --no-headers=true | awk '/^istio/ {print $1}' | xargs kubectl delete validatingwebhookconfiguration
kubectl get mutatingwebhookconfiguration --no-headers=true | awk '/^istio/ {print $1}' | xargs kubectl delete mutatingwebhookconfiguration

[kfaseela]

is this already sorted out? Or any help needed?

[howardjohn]

There was some discussion on #docs. its not sorted out

[craigbox]

I've identified the things that I think are causing the flakes, and would love to have someone take a look at trying to fix them.

Some that are in separate issues already:

• authz-tcp doctest flake #15505
• test flake: Envoy Filter retries #15603
• Cleanup is not deleting webhooks istio#36905

[kfaseela]

/retest

[kfaseela]

/test doc.test.multicluster

[kfaseela]

@nshankar13 : any idea about the multi-cluster failures?

[kfaseela]

/test doc.test.profile-none

[kfaseela]

@howardjohn @craigbox @dhawton I was finally able to run the multicluster test locally, and want to ask you if you can review the below Pr and get it merged, so that we can rerun the multicluster test here.. There are certain tests that have got mixed, and some steps which are supposed to be run only in non gateway api cases seem to be running in gateway api test as well. So may be we can fix that first and then would like to rerun this.

#15662

Background for the fix: The failing gwapi test here, says egress gateway cannot be deployed, while the document clearly says we can skip those steps for gateway api.

https://storage.googleapis.com/istio-prow/pr-logs/pull/istio_istio.io/15595/doc.test.multicluster_istio.io/1830594623492329472/artifacts/tests-setup-multicluster-a9bbe6/TestDocs/setup/install/external-controlplane/gtwapi_test.sh/gtwapi_test.sh/_test_context/gtwapi_test.sh_output.txt

[craigbox]

Done

[kfaseela]

/test doc.test.multicluster

[kfaseela]

while the gwapi test passed this time, the webhook deletion failure is still there. let me debug that now

[kfaseela]

The external control plane test is fixed, now what is left is the cleanup.. Pushed a fix for it, let us see how it goes

[kfaseela]

after latest rebase, there is a new failure on authz-tcp test

[dhawton]

/test doc.test.profile-default

This looks like a flake?

[kfaseela]

/test doc.test.profile-none

[kfaseela]

I am not able to debug further on the skywalking test failure, if there are no other pointers, may be we can disable the test so that atleast this PR can move forward. The failing test can be debugged in a fresh new PR?

[dhawton]

I am not able to debug further on the skywalking test failure, if there are no other pointers, may be we can disable the test so that atleast this PR can move forward. The failing test can be debugged in a fresh new PR?

I'm ok with that. I haven't had much luck and lack cycles for it.

[kfaseela]

I have raised an issue for skywalking test failure, and disabled the test on this PR, as this is blocking many things now! #15680

[kfaseela]

The new failure is on spire integration test.

Error: generate config: helm render: render chart: template: base/templates/services.yaml:1:14: executing "base/templates/services.yaml" at <.Values.global.remotePilotAddress>: nil pointer evaluating interface {}.remotePilotAddress

[kfaseela]

Have fixed the multiple controlplane and spire failures, hopefully this passes all tests atleast this time :(