Update reference doc updater #15880
Merged
Update reference doc updater #15880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istio-testing
added
the
size/S
istio-testing
added
size/XS
kfaseela
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The refdocs updater was broken by #15595. This fixes the problem introduced there and also a problem that occurs locally with go 1.18 or higher.
Trying to build each command line tool would give the error
because updated version information written to go binaries includes VCS information, and something about the build container doesn't have the right permissions to read that data. I have no idea if the container would fail the same way under the automator but as the file is built only to generate its CLI output and immediately deleted, we can just disable this feature.