Unscheduled DFCIR & SystemVerilog output path options revamp #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CIR output path was added.
ssmolov
reviewed
Jul 29, 2024
README.md
Outdated
| @@ -216,13 +216,16 @@ The list of arguments for `hls`-mode is presented below: | |||
|
|
|||
| * `-h,--help`: *optional* flag; used to print the help-message about other arguments. | |||
| * `--config <PATH>`: *required* filesystem-path option; used to specify the file for a JSON latency configuration file. Its format is presented in *JSON Configuration* section. | |||
| * `--out <NAME>`: *optional* filesystem-path option; used to specify the destination file for the output SystemVerilog to be generated in. If the name isn't provided or the provided name is an empty string, standard output stream is used. | |||
| * `--sv_out <PATH>`: *optional* filesystem-path option; used to specify the destination file for the output SystemVerilog to be generated in. | |||
There was a problem hiding this comment.
- "destination file for the output SystemVerilog to be generated in" -> "output SystemVerilog file"
- "--sv_out" -> "--out-sv"
README.md
Outdated
| @@ -216,13 +216,16 @@ The list of arguments for `hls`-mode is presented below: | |||
|
|
|||
| * `-h,--help`: *optional* flag; used to print the help-message about other arguments. | |||
| * `--config <PATH>`: *required* filesystem-path option; used to specify the file for a JSON latency configuration file. Its format is presented in *JSON Configuration* section. | |||
| * `--out <NAME>`: *optional* filesystem-path option; used to specify the destination file for the output SystemVerilog to be generated in. If the name isn't provided or the provided name is an empty string, standard output stream is used. | |||
| * `--sv_out <PATH>`: *optional* filesystem-path option; used to specify the destination file for the output SystemVerilog to be generated in. | |||
| * `--dfcir_out <PATH>`: *optional* filesystem-path option; used to specify the destination file for the output DFCIR to be generated in. | |||
There was a problem hiding this comment.
- "destination file for the output DFCIR to be generated in" -> "output DFCIR file"
-
- "--dfcir_out" -> "--out-dfcir"
README.md
Outdated
| * `-a` or `-l`: *required* flag; used to specify the chosen scheduling strategy - either as-soon-as-possible or linear programming. **Exactly one of these flags has to be specified**. | ||
|
|
||
| **At least one of the `*_out` options has to be specified.** |
README.md
Outdated
| Here is an example of an Utopia HLS CLI call: | ||
|
|
||
| ```bash | ||
| umain hls --config ~/utopia-user/config.json --out ~/outFile -a | ||
| umain hls --config ~/utopia-user/config.json --sv_out ~/outFile.sv --dfcir_out ~/outFile2.mlir -a |
There was a problem hiding this comment.
Fix options as are described above
src/options.h
Outdated
Comment on lines
38
to
39
| #define SV_OUT_JSON "sv_out" | ||
| #define DFCIR_OUT_JSON "dfcir_out" |
src/options.h
Outdated
Comment on lines
50
to
51
| #define SV_OUT_ARG CLI_ARG("sv_out") | ||
| #define DFCIR_OUT_ARG CLI_ARG("dfcir_out") |
src/options.h
Outdated
Comment on lines
184
to
187
| "Path to output SystemVerilog module to"); | ||
| outputGroup->add_option(DFCIR_OUT_ARG, | ||
| outNames[OUT_FORMAT_ID_INT(DFCIR)], | ||
| "Path to output unscheduled DFCIR to"); |
ssmolov
approved these changes
Jul 30, 2024
This was referenced Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unscheduled DFCIR option requested in #25 was added. SystemVerilog output path is no longer the only output option, thus its strict requirement was removed from both
README.mdand the codebase.