Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update min OS to Ubuntu 20.04 #6902

Merged
merged 9 commits into from
Aug 9, 2024
Merged

Update min OS to Ubuntu 20.04 #6902

merged 9 commits into from
Aug 9, 2024

Conversation

ssheorey
Copy link
Member

@ssheorey ssheorey commented Jul 31, 2024

Drop support for Ubuntu 18.04 since >1 year since Ubuntu 18.04 EOL.

Changes:

  • Move CI from bionic + focal to focal + jammy.
  • Remove workaround for CPU rendering on bionic.
  • Simplify CUDA arch selection code, add support for Hopper.

Type

  • Bug fix (non-breaking change which fixes an issue): Fixes #
  • New feature (non-breaking change which adds functionality). Resolves #
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation and Context

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description

Copy link

update-docs bot commented Jul 31, 2024

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@ssheorey ssheorey force-pushed the ss/ubuntu-20.04-24.04 branch 2 times, most recently from 3c4cff0 to 2576d1d Compare August 2, 2024 23:57
Fix CUDAARCHS in Windows CI, since no GPU present.
ARM Linux: Fix for "cannot allocate memory in TLS blck"
@ssheorey ssheorey requested a review from benjaminum August 6, 2024 06:58
Copy link
Contributor

@benjaminum benjaminum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I just have a small question, see comment

util/ci_utils.sh Show resolved Hide resolved
@ssheorey ssheorey merged commit e86fcb3 into main Aug 9, 2024
39 of 45 checks passed
@ssheorey ssheorey deleted the ss/ubuntu-20.04-24.04 branch August 9, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants