-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add O3DVisualizer API to enable collapse control of verts in the side panel #6865
Conversation
* Add API SetCollapsableVertOpen to control the toggling of the verts in the side panel
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @EwingKang thanks for this PR.
One suggestion to simplify this is to addCollapsableVert::GetText()
in Layout.cpp
. This way, there is no need to store the text -> pointer map. You can instead iterate through all the children of the vert panel and just match the text.
Also, please add python bindings.
Hi @ssheorey However, for the pointers suggestion, do you suggest having a |
See the discussions in PR isl-org#6865
c7106d7
to
284cd2c
Compare
…CollapsableVertOpen
284cd2c
to
e965381
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good after a few minor updates. Thanks @EwingKang
See discussions in PR isl-org#6865
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @EwingKang Looks good!
Add API SetCollapsableVertOpen to control the toggling of the verts in the side panel
Type
Motivation and Context
When we have start the viewer with side panel ("show settings"), the default toggle vert (pane) in the side panel defaults to ON for the "Mouse Controls" and "Scene", but no "Lighting". These default on panels took a lot of space and I find myself always collapsing the settings since I mostly want to control the visibility of objects in "Geometries". This becomes quite annoying very soon.
Checklist:
python util/check_style.py --apply
to apply Open3D code styleto my code.
updated accordingly.
results (e.g. screenshots or numbers) here.
Description
Before: Side vert "Mouse Controls" and "Scene" always defaults to ON
After The displayed result after calling the new API