Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade embree to 4.3.1 #6665

Merged
merged 6 commits into from
Mar 18, 2024
Merged

Conversation

lumurillo
Copy link
Contributor

@lumurillo lumurillo commented Feb 24, 2024

Upgrade the embree version to 4.3.1.

Type

  • Bug fix (non-breaking change which fixes an issue): Fixes #
  • New feature (non-breaking change which adds functionality). Resolves #
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation and Context

Use of the version 4 of the embree API.

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description

Copy link

update-docs bot commented Feb 24, 2024

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@lumurillo lumurillo marked this pull request as ready for review February 25, 2024 18:22
@ssheorey ssheorey requested a review from benjaminum February 26, 2024 19:39
@ssheorey
Copy link
Member

@lumurillo for style check:

pip install clang-format~=10.0
python util/check_style.py --apply

@ssheorey
Copy link
Member

ssheorey commented Feb 27, 2024

  • Please update to the latest available embree (4.3.1) - supports macOS ARM.
  • We will need to test GPU functionality.

@lumurillo lumurillo changed the title Upgrade embree to 4.0.0 Upgrade embree to 4.3.0 Mar 4, 2024
@lumurillo lumurillo changed the title Upgrade embree to 4.3.0 Upgrade embree to 4.3.1 Mar 4, 2024
@ssheorey
Copy link
Member

ssheorey commented Mar 6, 2024

Plan for embree upgrade:

  • Upgrade embree to latest and update API.
  • Pass CI on CPU.

Separate PR [copy this comment over to new PR]:

  • Add iGPU (SYCL) support and pass CI on iGPU.
  • Add dGPU (SYCL) support for Intel GPU and update / pass CI on dGPU.
  • [Future PR / Optional] Add dGPU (SYCL) support for Nvidia GPU and pass CI on dGPU. (device: ext_oneapi_cuda:gpu:0) with Codeplay oneAPI CUDA plugin.

@ssheorey
Copy link
Member

Hi @lumurillo did you notice any performance difference with the new embree, especially after the change in API (rtcInterset1M -> rtcIntersect1). It would be good to do a quick benchmark on a large mesh (~1M+ vertices).

@ssheorey ssheorey merged commit cac37c7 into isl-org:main Mar 18, 2024
33 of 36 checks passed
sitic added a commit to sitic/Open3D that referenced this pull request Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants