Skip to content

Commit

Permalink
Misc updates
Browse files Browse the repository at this point in the history
  • Loading branch information
ssheorey committed Jan 3, 2025
1 parent 0adbb2c commit 1da2f5d
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 14 deletions.
3 changes: 1 addition & 2 deletions cpp/apps/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,10 @@ macro(open3d_add_app_gui SRC_DIR APP_NAME TARGET_NAME)
set(MACOSX_BUNDLE_NAME ${APP_NAME})
set(MACOSX_BUNDLE_EXECUTABLE_NAME ${APP_NAME})
set(MACOSX_BUNDLE_GUI_IDENTIFIER com.isl-org.open3d.${APP_NAME})
set(MACOSX_BUNDLE_ICON_FILE "AppIcon")
set(MACOSX_BUNDLE_LONG_VERSION_STRING ${PROJECT_VERSION_THREE_NUMBER})
set(MACOSX_BUNDLE_SHORT_VERSION_STRING ${PROJECT_VERSION_THREE_NUMBER})
set(MACOSX_BUNDLE_BUNDLE_VERSION ${PROJECT_VERSION_THREE_NUMBER})
set(MACOSX_BUNDLE_COPYRIGHT "Copyright (c) 2018-2023 www.open3d.org")
set(MACOSX_BUNDLE_COPYRIGHT "Copyright (c) 2018-2025 www.open3d.org")
endif()

# Copy the resource files. This needs to be done as a post-build step
Expand Down
14 changes: 7 additions & 7 deletions cpp/apps/Open3DViewer/Info.plist.in
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@
<key>CFBundleGetInfoString</key>
<string>${MACOSX_BUNDLE_INFO_STRING}</string>
<key>CFBundleIconFile</key> <!-- macOS 10.12-; uses .icns file -->
<string>${MACOSX_BUNDLE_ICON_FILE}</string>
<string>AppIcon</string>
<key>CFBundleIconName</key> <!-- macOS 10.13+; requires Assets.car -->
<string>${MACOSX_BUNDLE_ICON_FILE}</string>
<string>AppIcon</string>
<key>CFBundleIdentifier</key>
<string>${MACOSX_BUNDLE_GUI_IDENTIFIER}</string>
<key>CFBundleInfoDictionaryVersion</key>
Expand Down Expand Up @@ -77,11 +77,11 @@
<key>LSHandlerRank</key>
<string>Owner</string>
</dict>
<dict> <!-- GLTB -->
<dict> <!-- GLB -->
<key>CFBundleTypeIconFile</key>
<string>documentIcon</string>
<key>CFBundleTypeName</key>
<string>GL Binary Transmission Format</string>
<string>GL Transmission Format (Binary)</string>
<key>CFBundleTypeRole</key>
<string>Editor</string>
<key>LSIsAppleDefaultForType</key>
Expand Down Expand Up @@ -318,7 +318,7 @@
</array>
<key>public.mime-type</key>
<array>
<string>model/gltf</string>
<string>model/gltf+json</string>
</array>
</dict>
</dict>
Expand All @@ -332,7 +332,7 @@
<string>public.data</string>
</array>
<key>UTTypeDescription</key>
<string>GL Binary Transmission Format</string>
<string>GL Transmission Format (Binary)</string>
<key>UTTypeTagSpecification</key>
<dict>
<key>public.filename-extension</key>
Expand All @@ -341,7 +341,7 @@
</array>
<key>public.mime-type</key>
<array>
<string>model/glb</string>
<string>model/glb-binary</string>
</array>
</dict>
</dict>
Expand Down
2 changes: 1 addition & 1 deletion cpp/apps/Open3DViewer/Open3DViewer.xml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
</mime-type>

<mime-type type="model/gltf-binary">
<comment>GL Transmission Format</comment>
<comment>GL Transmission Format (Binary)</comment>
<glob pattern="*.glb"/>
</mime-type>

Expand Down
5 changes: 1 addition & 4 deletions cpp/open3d/visualization/visualizer/GuiVisualizer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1166,10 +1166,7 @@ void GuiVisualizer::LoadGeometry(const std::string &path) {
model_success = false;
}
}
if (!model_success) {
utility::LogInfo("{} appears to be a point cloud", path.c_str());
}

// path appears to be a point cloud...
auto geometry = std::shared_ptr<geometry::Geometry3D>();
if (!model_success) {
auto cloud = std::make_shared<geometry::PointCloud>();
Expand Down

0 comments on commit 1da2f5d

Please sign in to comment.