Solver details #14
Merged
Solver details #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jp7745
requested changes
Nov 19, 2024
There was a problem hiding this comment.
Please:
remove short_name from the top-level required fields
add solver_short_name as a required string field inside of the solver_details object. This is just a human-readable, possibly NOT unique field describing the solver. make it a required field.
any details on the classical_compute_details can be optional for now.
Currently I'm struggling with the premise that we have made some bespoke scripts and analysis that key off of FCIDUMP files specifically, not task_uuid. In general, I see the value of adding task_uuid to the problem_instance JSON.
Changing the problem_instance schema to include task_uuid will break some scripts and require updating and regression testing. I believe that our partners are also working on problem_instance.json files and they will have to update their JSON as well. Be sure to offer to help our partners update their problem_instance files.
|
***@***.***
*We intend the |task_uuid| to be the same as the FCIDUMP uuid, partly to
emphasize that the FCIDUMP uuid is the ground source of truth.
Would this ease any backwards compatibility concerns?
…On 2024-11-19 15:50, John Penuel wrote:
***@***.**** requested changes on this pull request.
------------------------------------------------------------------------
On schemas/solution.schema.0.0.1.json
<#14 (comment)>:
Please:
remove |short_name| from the top-level required fields
add |solver_short_name| as a required string field inside of the
|solver_details| object. This is just a human-readable, possibly NOT
unique field describing the solver. make it a required field.
any details on the |classical_compute_details| can be optional for now.
Currently I'm struggling with the premise that we have made some
bespoke scripts and analysis that key off of FCIDUMP files
specifically, not |task_uuid|. In general, I see the value of adding
|task_uuid| to the |problem_instance| JSON.
Changing the |problem_instance| schema to include |task_uuid| will
break some scripts and require updating and regression testing. I
believe that our partners are also working on |problem_instance.json|
files and they will have to update their JSON as well. Be sure to
offer to help our partners update their |problem_instance| files.
—
Reply to this email directly, view it on GitHub
<#14 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABC6NAKZCMZO6EUXAK4XS732BOQBXAVCNFSM6AAAAABSBAUCQSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDINBWGYZDMMRZHA>.
You are receiving this because you are subscribed to this
thread.Message ID:
***@***.***>
--------------fWZvAiduskHHnrYaPrA8ep6O
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit
<!DOCTYPE html><html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
***@***.*** <br>
</b>We intend the <code class="notranslate">task_uuid</code> to be
the same as the FCIDUMP uuid, partly to emphasize that the FCIDUMP
uuid is the ground source of truth.<br>
Would this ease any backwards compatibility concerns?<br>
<br>
<br>
<div class="moz-cite-prefix">On 2024-11-19 15:50, John Penuel wrote:<br>
</div>
<blockquote type="cite" ***@***.***">
***@***.***</b> requested changes on this pull request.</p>
<hr>
<p>On <a href="#14 (comment)" moz-do-not-send="true">schemas/solution.schema.0.0.1.json</a>:</p>
<p dir="auto">Please:</p>
<p dir="auto">remove <code class="notranslate">short_name</code>
from the top-level required fields</p>
<p dir="auto">add <code class="notranslate">solver_short_name</code>
as a required string field inside of the <code class="notranslate">solver_details</code> object. This is just
a human-readable, possibly NOT unique field describing the
solver. make it a required field.</p>
<p dir="auto">any details on the <code class="notranslate">classical_compute_details</code>
can be optional for now.</p>
<p dir="auto">Currently I'm struggling with the premise that we
have made some bespoke scripts and analysis that key off of
FCIDUMP files specifically, not <code class="notranslate">task_uuid</code>.
In general, I see the value of adding <code class="notranslate">task_uuid</code>
to the <code class="notranslate">problem_instance</code> JSON.</p>
<p dir="auto">Changing the <code class="notranslate">problem_instance</code>
schema to include <code class="notranslate">task_uuid</code>
will break some scripts and require updating and regression
testing. I believe that our partners are also working on <code class="notranslate">problem_instance.json</code> files and
they will have to update their JSON as well. Be sure to offer to
help our partners update their <code class="notranslate">problem_instance</code>
files.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br>
Reply to this email directly, <a href="#14 (review)" moz-do-not-send="true">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABC6NAKZCMZO6EUXAK4XS732BOQBXAVCNFSM6AAAAABSBAUCQSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDINBWGYZDMMRZHA" moz-do-not-send="true">unsubscribe</a>.<br>
You are receiving this because you are subscribed to this
thread.<img src="https://github.com/notifications/beacon/ABC6NANUGEILKIBD4GOWU232BOQBXA5CNFSM6AAAAABSBAUCQSWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTUR2SG7U.gif" height="1" width="1" alt="" moz-do-not-send="true"><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message
ID: <span><isi-usc-edu/qb-gsee-benchmark/pull/14/review/2446626298</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
***@***.***": "http://schema.org",
***@***.***": "EmailMessage",
"potentialAction": {
***@***.***": "ViewAction",
"target": "#14 (review)",
"url": "#14 (review)",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
***@***.***": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
</blockquote>
<br>
</body>
</html>
--------------fWZvAiduskHHnrYaPrA8ep6O--
|
|
At this time, it's ok to update |
|
To clarify: I'm ok with updating Note also that the automatic JSON validation script will probably trash all of our |
|
I've changed the short name related fields in the solution schema.
I believe the classical details fields (classical_resources and
classical_hardware_details) and their subfields are all already optional
in the solution schema, though let me know if I missed what you were
referring to.
And, yes, I can help Matt/HRL with the task uuids.
…On 2024-11-19 16:30, John Penuel wrote:
To clarify: I'm ok with updating |problem_instance.schema| to include
|task_uuid|. I'm asking for additional /minor changes/ to the
|solution.schema| like removing |short_name| and adding
|solver_short_name| to the |solver_details| object before we merge.
Note also that the automatic JSON validation script will probably
trash all of our |problem_instance| files. You'll have to pull them
out of the |/json_files_with_errors| directory.
—
Reply to this email directly, view it on GitHub
<#14 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABC6NAILQCO5UFQC3CR3VED2BOUV7AVCNFSM6AAAAABSBAUCQSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBWG44TCMZTGI>.
You are receiving this because you commented.Message ID:
***@***.***>
--------------mgUGMfnofq2wSABo0FcnMU0e
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit
<!DOCTYPE html><html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
I've changed the short name related fields in the solution schema.<br>
<br>
I believe the classical details fields (classical_resources and
classical_hardware_details) and their subfields are all already
optional in the solution schema, though let me know if I missed what
you were referring to.<br>
<br>
And, yes, I can help Matt/HRL with the task uuids.<br>
<br>
<br>
<br>
<br>
<div class="moz-cite-prefix">On 2024-11-19 16:30, John Penuel wrote:<br>
</div>
<blockquote type="cite" ***@***.***">
<p dir="auto">To clarify: I'm ok with updating <code class="notranslate">problem_instance.schema</code> to include
<code class="notranslate">task_uuid</code>. I'm asking for
additional <em>minor changes</em> to the <code class="notranslate">solution.schema</code> like removing <code class="notranslate">short_name</code> and adding <code class="notranslate">solver_short_name</code> to the <code class="notranslate">solver_details</code> object before we
merge.</p>
<p dir="auto">Note also that the automatic JSON validation script
will probably trash all of our <code class="notranslate">problem_instance</code>
files. You'll have to pull them out of the <code class="notranslate">/json_files_with_errors</code> directory.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br>
Reply to this email directly, <a href="#14 (comment)" moz-do-not-send="true">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABC6NAILQCO5UFQC3CR3VED2BOUV7AVCNFSM6AAAAABSBAUCQSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBWG44TCMZTGI" moz-do-not-send="true">unsubscribe</a>.<br>
You are receiving this because you commented.<img src="https://github.com/notifications/beacon/ABC6NAIRV4T26TN36JPAB6D2BOUV7A5CNFSM6AAAAABSBAUCQSWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUUHFWKI.gif" height="1" width="1" alt="" moz-do-not-send="true"><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message
ID: <span><isi-usc-edu/qb-gsee-benchmark/pull/14/c2486791332</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
***@***.***": "http://schema.org",
***@***.***": "EmailMessage",
"potentialAction": {
***@***.***": "ViewAction",
"target": "#14 (comment)",
"url": "#14 (comment)",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
***@***.***": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
</blockquote>
<br>
</body>
</html>
--------------mgUGMfnofq2wSABo0FcnMU0e--
|
jp7745
approved these changes
Nov 19, 2024
This was referenced Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a number of changes to the problem and solution schemas to allow for more details about the solver to be reported. See #12 for more context.
Note also that the plan is to not include aggregated resources in the schema (e.g. total number of T gates across all tasks). Instead, resources should be provided on a per-task basis and any desired aggregation can be done in post-processing.
Changes to problem schema:
data_instance_objectsrenamed totasksfor more clarity.task_uuidfield to elements oftasks.Changes to solution schema:
classical_resources,quantum_resources, andsolution_detailsfields to elements ofsolution_data.instance_data_object_uuidtotask_uuid.compute_detailstosolver_detailsfor consistency.solver_uuidtosolver_details.compute_hardware_typeintosolver_details.run_timeno longer required for resource estimates in order to allow for reporting of logical resource estimates.classical_hardware_details,quantum_hardware_details,algorithm_details, andsoftware_detailsfields tosolver_details.