Fixes to schemas and problem instances #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, I've done this too on branch *jtcantin-problem_instance_updates
<https://github.com/isi-usc-edu/qb-gsee-benchmark/tree/jtcantin-problem_instance_updates>,
including for the planted solutions and coarse set.
I am planning to add several reference energies next.
@max, can you check if our schema fixes are the same?
*
…On 2024-11-19 20:47, Max Radin wrote:
This PR fixes a few mistakes in the solution schema and also updates
the problem instances that were removed by CI in the last commit to
comply with the new schemas. Note that each task has been assigned a
new UUID that differs from the fcidump UUIDs, as discussed in #14
<#14>.
------------------------------------------------------------------------
You can view, comment on, or merge this pull request online at:
#21
Commit Summary
* 2802ed8
<2802ed8>
Fixes to schemas
File Changes
(2 files <https://github.com/isi-usc-edu/qb-gsee-benchmark/pull/21/files>)
* *M* schemas/problem_instance.schema.0.0.1.json
<https://github.com/isi-usc-edu/qb-gsee-benchmark/pull/21/files#diff-5a976c3989732072de5ad34f9194134955ad8473f9585a50ad22e1a6a50016eb>
(2)
* *M* schemas/solution.schema.0.0.1.json
<https://github.com/isi-usc-edu/qb-gsee-benchmark/pull/21/files#diff-1822086ff12d22a9485d35b52b6340649c556c3fe3cc3983b8959fa462fc5d60>
(18)
Patch Links:
* https://github.com/isi-usc-edu/qb-gsee-benchmark/pull/21.patch
* https://github.com/isi-usc-edu/qb-gsee-benchmark/pull/21.diff
—
Reply to this email directly, view it on GitHub
<#21>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABC6NAOTUUCTJNTJ2SDRBRD2BPS2LAVCNFSM6AAAAABSDORBOCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGY3TIMBWGA2TQMI>.
You are receiving this because you are subscribed to this
thread.Message ID: ***@***.***>
--------------ZyiGaxY5IP0XGrr17lNoUZkM
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit
<!DOCTYPE html><html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
Ah, I've done this too on branch <strong style="box-sizing: border-box; font-weight: var(--base-text-weight-semibold, 600); color: rgb(31, 35, 40); font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", "Noto Sans", Helvetica, Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji"; font-size: 14px; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; white-space: normal; background-color: rgb(255, 255, 255); text-decoration-thickness: initial; text-decoration-style: initial; text-decoration-color: initial;"><a rel="nofollow" class="Link--primary break-line-anywhere" title="jtcantin-problem_instance_updates" href="https://github.com/isi-usc-edu/qb-gsee-benchmark/tree/jtcantin-problem_instance_updates" style="box-sizing: border-box; background-color: transparent; color: var(--fgColor-default) !important; text-decoration: none; line-break: anywhere !important;">jtcantin-problem_instance_updates</a>,
including for the planted solutions and coarse set.<br>
<br>
I am planning to add several reference energies next.<br>
<br>
@max, can you check if our schema fixes are the same?<br>
</strong><br>
<br>
<div class="moz-cite-prefix">On 2024-11-19 20:47, Max Radin wrote:<br>
</div>
<blockquote type="cite" ***@***.***">
<p dir="auto">This PR fixes a few mistakes in the solution schema
and also updates the problem instances that were removed by CI
in the last commit to comply with the new schemas. Note that
each task has been assigned a new UUID that differs from the
fcidump UUIDs, as discussed in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2670515280" data-permission-text="Title is private" data-url="#14" data-hovercard-type="pull_request" data-hovercard-url="/isi-usc-edu/qb-gsee-benchmark/pull/14/hovercard" href="#14" moz-do-not-send="true">#14</a>.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online
at:</h4>
<p> <a href="#21" moz-do-not-send="true" class="moz-txt-link-freetext">#21</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href="2802ed8" class="commit-link" moz-do-not-send="true">2802ed8</a> Fixes
to schemas</li>
</ul>
<h4 style="display: inline-block">File Changes </h4>
<p style="display: inline-block">(<a href="https://github.com/isi-usc-edu/qb-gsee-benchmark/pull/21/files" moz-do-not-send="true">2 files</a>)</p>
<ul>
<li> <strong>M</strong> <a href="https://github.com/isi-usc-edu/qb-gsee-benchmark/pull/21/files#diff-5a976c3989732072de5ad34f9194134955ad8473f9585a50ad22e1a6a50016eb" moz-do-not-send="true">schemas/problem_instance.schema.0.0.1.json</a>
(2) </li>
<li> <strong>M</strong> <a href="https://github.com/isi-usc-edu/qb-gsee-benchmark/pull/21/files#diff-1822086ff12d22a9485d35b52b6340649c556c3fe3cc3983b8959fa462fc5d60" moz-do-not-send="true">schemas/solution.schema.0.0.1.json</a>
(18) </li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href="https://github.com/isi-usc-edu/qb-gsee-benchmark/pull/21.patch" moz-do-not-send="true" class="moz-txt-link-freetext">#21.patch</a></li>
<li><a href="https://github.com/isi-usc-edu/qb-gsee-benchmark/pull/21.diff" moz-do-not-send="true" class="moz-txt-link-freetext">#21.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br>
Reply to this email directly, <a href="#21" moz-do-not-send="true">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABC6NAOTUUCTJNTJ2SDRBRD2BPS2LAVCNFSM6AAAAABSDORBOCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGY3TIMBWGA2TQMI" moz-do-not-send="true">unsubscribe</a>.<br>
You are receiving this because you are subscribed to this
thread.<img src="https://github.com/notifications/beacon/ABC6NAKDZJL4WIRMV5OWTA32BPS2LA5CNFSM6AAAAABSDORBOCWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHJ6YXNEU.gif" height="1" width="1" alt="" moz-do-not-send="true"><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message
ID: <span><isi-usc-edu/qb-gsee-benchmark/pull/21</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
***@***.***": "http://schema.org",
***@***.***": "EmailMessage",
"potentialAction": {
***@***.***": "ViewAction",
"target": "#21",
"url": "#21",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
***@***.***": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
</blockquote>
<br>
</body>
</html>
--------------ZyiGaxY5IP0XGrr17lNoUZkM--
|
|
Actually, I'll just pull this branch into mine and resolve any merge conflicts that may arise. |
|
@max-radin This PR for branch |
|
Whoops, opened a PR for the wrong branch. Will close and make a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few mistakes in the solution schema and also updates the problem instances that were removed by CI in the last commit to comply with the new schemas. Note that each task has been assigned a new UUID that differs from the fcidump UUIDs, as discussed in #14.