-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds distance_to_camera
datatype in TiledCamera
#889
Conversation
TiledCamera
to distance_to_cameraTiledCamera
to distance_to_camera
TiledCamera
to distance_to_camera
distance_to_camera
datatype in TiledCamera
distance_to_camera
datatype in TiledCamera
distance_to_camera
datatype in TiledCamera
Do we know if the TiledCamera will get the distance_to_image_plane data type. We noticed last night what depth actually meant when converting to point cloud. The depth to point cloud function in IsaacLab assumes the distance_to_image_plane as the input data. |
This will be addressed as part of the update to the new tiled rendering API in isaac sim coming in the release. depth will become an alias to distance_to_image_plane |
as soon as the change of the new API becomes available, we can convert |
source/extensions/omni.isaac.lab/omni/isaac/lab/sensors/camera/tiled_camera.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
@pascal-roth Can you add a ticket to do this if it doesn't already exist? |
@jsmith-bdai out test will fail anyway as soon as the renaming takes place. I would avoid to have another issue open about that topic if this will anyway remind us, or what do you think about it? |
# Description Added the data type "distance_to_camera" in the `TiledCamera` class to be consistent with all other cameras. This data type is equal to the "depth" datatype. ## Type of change - New feature (non-breaking change which adds functionality) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
Description
Added the data type "distance_to_camera" in the
TiledCamera
class to be consistent with all other cameras. This data type is equal to the "depth" datatype.Type of change
Checklist
pre-commit
checks with./isaaclab.sh --format
config/extension.toml
fileCONTRIBUTORS.md
or my name already exists there