Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds distance_to_camera datatype in TiledCamera #889

Merged
merged 8 commits into from
Sep 5, 2024

Conversation

pascal-roth
Copy link
Collaborator

@pascal-roth pascal-roth commented Aug 28, 2024

Description

Added the data type "distance_to_camera" in the TiledCamera class to be consistent with all other cameras. This data type is equal to the "depth" datatype.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@pascal-roth pascal-roth added the enhancement New feature or request label Aug 28, 2024
@pascal-roth pascal-roth self-assigned this Aug 28, 2024
@pascal-roth pascal-roth changed the title Renames depth datatype in TiledCamera to distance_to_camera Renames depth datatype in TiledCamera to distance_to_camera Aug 28, 2024
@pascal-roth pascal-roth changed the title Renames depth datatype in TiledCamera to distance_to_camera Add distance_to_camera datatype in TiledCamera Aug 28, 2024
@pascal-roth pascal-roth changed the title Add distance_to_camera datatype in TiledCamera Adds distance_to_camera datatype in TiledCamera Aug 28, 2024
@jtigue-bdai
Copy link
Collaborator

Do we know if the TiledCamera will get the distance_to_image_plane data type. We noticed last night what depth actually meant when converting to point cloud. The depth to point cloud function in IsaacLab assumes the distance_to_image_plane as the input data.

@kellyguo11
Copy link
Contributor

This will be addressed as part of the update to the new tiled rendering API in isaac sim coming in the release. depth will become an alias to distance_to_image_plane

@pascal-roth
Copy link
Collaborator Author

as soon as the change of the new API becomes available, we can convert depth_to_image_plane in the entire code to depth. For now, this change here should be necessary to keep our interface similar over all camera implementations.

@pascal-roth pascal-roth added the dev team Issue or pull request created by the dev team label Aug 28, 2024
Copy link
Collaborator

@jtigue-bdai jtigue-bdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jsmith-bdai
Copy link
Collaborator

jsmith-bdai commented Aug 30, 2024

as soon as the change of the new API becomes available, we can convert depth_to_image_plane in the entire code to depth. For now, this change here should be necessary to keep our interface similar over all camera implementations.

@pascal-roth Can you add a ticket to do this if it doesn't already exist?

@pascal-roth
Copy link
Collaborator Author

@jsmith-bdai out test will fail anyway as soon as the renaming takes place. I would avoid to have another issue open about that topic if this will anyway remind us, or what do you think about it?

@Mayankm96 Mayankm96 merged commit b01447d into main Sep 5, 2024
3 checks passed
@Mayankm96 Mayankm96 deleted the fix/tiled-depth-rename branch September 5, 2024 07:34
iamdrfly pushed a commit to iamdrfly/IsaacLab that referenced this pull request Nov 21, 2024
# Description

Added the data type "distance_to_camera" in the `TiledCamera` class to
be consistent with all other cameras. This data type is equal to the
"depth" datatype.

## Type of change

- New feature (non-breaking change which adds functionality)

## Checklist

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./isaaclab.sh --format`
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [x] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev team Issue or pull request created by the dev team enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants