Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds dict conversion test for ActuatorBase configs #1608

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mschweig
Copy link

@mschweig mschweig commented Dec 28, 2024

Description

A recent PR (#1530 (comment)) causes issues with joint_parameter_lookup attributes of Articulation Configs. The class_to_dict utility function needs to return a primitive dict. Returning a torch.Tensor conflicts with OmegaConf.

This PR adds a unittest for the dict conversion as requested by @lgulich so that the issue can be fixed. The test case fails on main branch as expected according to my understanding. Passes on v1.3.0.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant