Adds dict conversion test for ActuatorBase configs #1608
+23
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A recent PR (#1530 (comment)) causes issues with joint_parameter_lookup attributes of Articulation Configs. The
class_to_dict
utility function needs to return a primitive dict. Returning a torch.Tensor conflicts with OmegaConf.This PR adds a unittest for the dict conversion as requested by @lgulich so that the issue can be fixed. The test case fails on main branch as expected according to my understanding. Passes on v1.3.0.
Type of change
Checklist
pre-commit
checks with./isaaclab.sh --format
config/extension.toml
fileCONTRIBUTORS.md
or my name already exists there