Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes MARL workflows for recording videos during training/inferencing #1596

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Rishi-V
Copy link

@Rishi-V Rishi-V commented Dec 24, 2024

Description

Fixing bug so that using training workflow on MARL workflow populates videos/train.
See #1595

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Screenshots

before_and_after
The first run was without the changes where we see videos/train empty. The second run is after the changes with videos/train successfully populated.

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • [N/A] I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • [Sort of] I have added tests that prove my fix is effective or that my feature works; I have verified that it works on train.py for skrl and rl_games. I have not verified rsl_rl or sb3 as well have not verified play.py on any of the four. However I have implemented the changes on all of them as they all seem to follow the exact same structure.
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there; Unsure if this fix is worth being labelled as a contributor, if so would be happy to be added to the contributors.md (full name is Rishi Veerapaneni).

@kellyguo11 kellyguo11 changed the title Fixing bug so that using training workflow on MARL workflow populates videos/train Fixes MARL workflows for recording videos during training/inferencing Dec 25, 2024
@Rishi-V
Copy link
Author

Rishi-V commented Dec 27, 2024

Update: I just reran my previous commands (after my "bug fix" changes) and for some reason am getting different buggy/erroring outcomes. I will test this more and get back to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant