Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds position threshold check for state transitions #1544

Merged
merged 7 commits into from
Dec 15, 2024

Conversation

kellyguo11
Copy link
Contributor

Description

Adds a position threshold check, resolving 3 TODO error comments, to ensure the robot's end effector is within a specified distance from the target position before transitioning between states in the pick and lift state machine. Improves the precision of state transitions and helps prevent premature actions during object manipulation. I.e, the threshold ensures the robot is "close enough" to the target position before proceeding, reducing the likelihood of failed grasps or incorrect movements.

PR adapted from #1273 by @DorsaRoh.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@kellyguo11 kellyguo11 changed the title Fixes position threshold check for state transitions Adds position threshold check for state transitions Dec 15, 2024
@kellyguo11 kellyguo11 merged commit 8ddc483 into isaac-sim:main Dec 15, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants