Fixes the initial state recorder term for multi-env use cases #1499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvcyc
requested review from
jsmith-bdai,
Dhoeller19,
kellyguo11 and
Mayankm96
as code owners
nvcyc
force-pushed
the
cy/fix_initial_state_recorder
branch
from
72b4a33 to
ddf0823
Compare
kellyguo11
approved these changes
Dec 10, 2024
kellyguo11
reviewed
Dec 11, 2024
Signed-off-by: Kelly Guo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the initial state recorder term to support multi-env use cases by returning only the states of the specified environment IDs, which allows the recorder to correctly retrieve and record the correct initial state for the given environment IDs.
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there