Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes noise_model initialized in direct_marl_env #1480

Merged
merged 5 commits into from
Dec 5, 2024
Merged

Fixes noise_model initialized in direct_marl_env #1480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d564a2a
Fix setting noise_model in direct_marl_env
Nov 29, 2024
5b9b40a
add name inCONTRIBUTORS
Nov 29, 2024
9377996
Merge branch 'main' into fix/marl-env-noisecfg
kellyguo11 Dec 4, 2024
5da75f7
Update extension.toml
kellyguo11 Dec 4, 2024
9bc80a3
Update CONTRIBUTORS.md
kellyguo11 Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CONTRIBUTORS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ Guidelines for modifications:
* Felix Yu
* Gary Lvov
* Giulio Romualdi
* Haoran Zhou
* HoJin Jeon
* Jan Kerner
* Jean Tampon
Expand Down
2 changes: 1 addition & 1 deletion source/extensions/omni.isaac.lab/config/extension.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[package]

# Note: Semantic Versioning is used: https://semver.org/
version = "0.27.17"
version = "0.27.18"

# Description
title = "Isaac Lab framework for Robot Learning"
Expand Down
9 changes: 9 additions & 0 deletions source/extensions/omni.isaac.lab/docs/CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,15 @@
Changelog
---------

0.27.18 (2024-12-04)
~~~~~~~~~~~~~~~~~~~~

Fixed
^^^^^

* Fixed the order of the incoming parameters in :class:`omni.isaac.lab.envs.DirectMARLEnv` to correctly use ``NoiseModel`` in marl-envs.


0.27.17 (2024-12-02)
~~~~~~~~~~~~~~~~~~~~

Expand Down
4 changes: 2 additions & 2 deletions source/extensions/omni.isaac.lab/omni/isaac/lab/envs/direct_marl_env.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,13 +175,13 @@ def __init__(self, cfg: DirectMARLEnvCfg, render_mode: str | None = None, **kwar
# setup noise cfg for adding action and observation noise
if self.cfg.action_noise_model:
self._action_noise_model: dict[AgentID, NoiseModel] = {
agent: noise_model.class_type(self.num_envs, noise_model, self.device)
agent: noise_model.class_type(noise_model, num_envs=self.num_envs, device=self.device)
for agent, noise_model in self.cfg.action_noise_model.items()
if noise_model is not None
}
if self.cfg.observation_noise_model:
self._observation_noise_model: dict[AgentID, NoiseModel] = {
agent: noise_model.class_type(self.num_envs, noise_model, self.device)
agent: noise_model.class_type(noise_model, num_envs=self.num_envs, device=self.device)
for agent, noise_model in self.cfg.observation_noise_model.items()
if noise_model is not None
}
Expand Down
Loading