Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes syntax for checking if pre-commit is installed in isaaclab.sh #1422

Merged
merged 8 commits into from
Dec 5, 2024

Conversation

louislelay
Copy link
Contributor

Description

When running ./isaaclab.sh --format for another pull request, I got a command not found error for pre-commit. Looking into the script, I found a condition to check if pre-commit was installed, but the syntax was off.

It was written like this:

if [ ! command -v pre-commit &>/dev/null ]; then

But it should be:

if ! command -v pre-commit &>/dev/null; then

I fixed it, and the script worked as expected, installing pre-commit when I ran it again.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@kellyguo11 kellyguo11 changed the title Fix syntax for checking if pre-commit is installed in isaaclab.sh Fixes syntax for checking if pre-commit is installed in isaaclab.sh Dec 5, 2024
Signed-off-by: Kelly Guo <[email protected]>
@kellyguo11 kellyguo11 merged commit dbb3d4a into isaac-sim:main Dec 5, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants