Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi-Robot setup and detection #767

Open
wants to merge 14 commits into
base: indigo_dev
Choose a base branch
from
Open

Multi-Robot setup and detection #767

wants to merge 14 commits into from

Conversation

ipa-srd-rd
Copy link

  • added multi-robot and simulation arguments to launch files where needed
  • removed absolute ros paths, since they do not allow namespacing
  • updated sensor range to max range (~30m)

ipa-srd-rd and others added 14 commits March 10, 2018 12:40
@ipa-srd-rd ipa-srd-rd mentioned this pull request Sep 25, 2018
Open
@ipa-srd-rd
Copy link
Author

Related to:
https://github.com/ipa320/ipa_navigation/pull/308
ipa320/cob_simulation#163
https://github.com/ipa320/cob_common/pull/259
https://github.com/ipa320/ipa_navigation_sandbox/pull/340
https://github.com/ipa320/ipa_navigation_localization/pull/389
https://github.com/ipa320/ipa_navigation_common/pull/242

@ipa-srd-rd ipa-srd-rd mentioned this pull request Sep 25, 2018
Closed
fmessmer
fmessmer requested changes Sep 25, 2018
View reviewed changes
Copy link
Member

@fmessmer fmessmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to keep all this "single_robot"
can you not outsource the multi_robot launch files to a new repo - say cob_multi_robots where you use subst_arg mechanism?

@fmessmer
Copy link
Member

there is an ugly file can_filter_chain: which seems to be added unintendedly...please remove

@ipa-srd-rd
Copy link
Author

there is an ugly file can_filter_chain: which seems to be added unintendedly...please remove

Removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmessmer fmessmer fmessmer requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ipa-srd-rd @fmessmer @dietriro