Feature/head and sensorring #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tested on cob4-10: OK |
fmessmer
reviewed
Jan 19, 2017
| @@ -116,21 +116,22 @@ | |||
| <arg name="robot" value="$(arg robot)"/> | |||
| <arg name="component_name" value="torso"/> | |||
| <arg name="can_device" value="can0"/> | |||
| <arg name="cartesian_control" value="true"/> | |||
There was a problem hiding this comment.
could you not just set the value to false?
here and wherever it applies...
There was a problem hiding this comment.
No, the default be kept in a single place.
| # sensorring: | ||
| # type: diagnostic_aggregator/GenericAnalyzer | ||
| # path: Sensorring | ||
| # contains: 'sensorring/driver' | ||
| # contains: 'sensorring/' |
There was a problem hiding this comment.
cob4-1 doesn't (yet) have a working sensorring hardware
| type: diagnostic_aggregator/GenericAnalyzer | ||
| path: twist_mux | ||
| contains: 'twist_mux' | ||
| contains: 'base/' |
There was a problem hiding this comment.
what happened to the twist_mux diagnostics?
doesn't this contains pattern conflict with e.g. base/light?
There was a problem hiding this comment.
light on base is using light_base namespace, so filtering works as expected
|
I put a note about the high load problem observed on real hardware caused by the |
4 tasks
fmessmer
approved these changes
Jan 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extends #568