feat(app): update design and functionality to match other conference apps and migrate google maps to leaflet #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced Apr 16, 2025
brandyscarney
requested review from
a team and
ShaneK
and removed request for
a team
thetaPC
requested changes
Apr 17, 2025
ShaneK
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated almost every page here and migrated from google maps to leaflet. The only functionality I didn't fix was the login/account functionality because this is pretty hefty as is.
The best way to test this is probably to compare this branch against main and the other conference apps:
Main Preview: https://ionic-vue-conference-app-git-main-ionic1.vercel.app/tutorial
Branch Preview: https://ionic-vue-conference-app-git-bc-fix-navigation-an-ad46b9-ionic1.vercel.app/tutorial
React PR: ionic-team/ionic-react-conference-app#133
React Preview: https://ionic-react-conference-app-git-bc-fix-navigation-ionic1.vercel.app/tutorial
Angular PR: ionic-team/ionic-conference-app#1821
Angular Preview: https://ionic-conference-app-git-bc-design-fixes-ionic1.vercel.app/tutorial