Skip to content

feat(app): update design and functionality to match other conference apps and migrate google maps to leaflet #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Apr 18, 2025

Conversation

brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Apr 15, 2025

I updated some of the page designs here to be consistent with the other conference apps and migrated from google maps to leaflet.

The best way to test this is probably to compare this branch against main and the other conference apps:

Main Preview: https://ionic-react-conference-app-git-main-ionic1.vercel.app/tutorial
Branch Preview: https://ionic-react-conference-app-git-bc-fix-navigation-ionic1.vercel.app/tutorial

Vue PR: ionic-team/ionic-vue-conference-app#55
Vue Preview: https://ionic-vue-conference-app-git-bc-fix-navigation-an-ad46b9-ionic1.vercel.app/tutorial

Angular PR: ionic-team/ionic-conference-app#1821
Angular Preview: https://ionic-conference-app-git-bc-design-fixes-ionic1.vercel.app/tutorial

Copy link

@gnbm gnbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

vercel bot commented Apr 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-react-conference-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2025 8:22pm

@brandyscarney brandyscarney changed the title fix(app): properly navigate between pages and resolve console logs fix(app): match design of other conference app and resolve console logs Apr 16, 2025
@brandyscarney brandyscarney changed the title fix(app): match design of other conference app and resolve console logs feat(app): match design of other conference app and resolve console logs Apr 16, 2025
@brandyscarney brandyscarney changed the title feat(app): match design of other conference app and resolve console logs feat(app): update design and functionality to match other conference apps and resolve console logs Apr 16, 2025
@brandyscarney brandyscarney changed the title feat(app): update design and functionality to match other conference apps and resolve console logs feat(app): update design and functionality to match other conference apps and migrate google maps to leaflet Apr 16, 2025
@brandyscarney brandyscarney requested review from a team and thetaPC and removed request for a team April 16, 2025 22:37
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandyscarney brandyscarney merged commit 11099be into main Apr 18, 2025
2 checks passed
@brandyscarney brandyscarney deleted the bc/fix-navigation branch April 18, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants