Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out the empty hosts from yves/zed on nginx conf.template #685

Merged

Conversation

Chemaclass
Copy link
Contributor

@Chemaclass Chemaclass commented Apr 28, 2022

Description

Allow defining null/empty external_hosts and filter them out from the conf.d yves|zed template.

@andytson-inviqa
Copy link
Contributor

Thanks for removing the merge, I was about to comment on that :)

@Chemaclass Chemaclass force-pushed the feature/filter-empty-external-hosts branch from fdfafb1 to 3c79f5f Compare April 28, 2022 10:43
@Chemaclass
Copy link
Contributor Author

Chemaclass commented Apr 28, 2022

@andytson-inviqa instead of using the raw-int 600, what about using @('php.fpm.ini.max_execution_time') for the other properties in zed.conf.template as well? Simillar as we currently do for the fastcgi_read_timeout:

proxy_read_timeout 600s;
proxy_send_timeout 600s;
fastcgi_read_timeout {{ @('php.fpm.ini.max_execution_time') + 1 }}s;
client_body_timeout 600s;
client_header_timeout 600s;
send_timeout 600s;

This could be done in this PR or in a follow-up PR.

UPDATED: I created an issue for this topic: #688

@andytson-inviqa
Copy link
Contributor

might be worth a github issue or PR to discuss that, as I'm not sure but others might have an opinion. This PR will be merged when the jenkins build passes

@andytson-inviqa andytson-inviqa merged commit 9d065bf into inviqa:1.4.x Apr 28, 2022
@Chemaclass Chemaclass deleted the feature/filter-empty-external-hosts branch April 28, 2022 13:24
@andytson-inviqa andytson-inviqa added enhancement New feature or request harness-spryker Spryker harness labels Apr 28, 2022
@andytson-inviqa andytson-inviqa added this to the 1.4.0 milestone May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request harness-spryker Spryker harness
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants