Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use max_execution_time variable on zed.conf.template #688

Open
Chemaclass opened this issue Apr 28, 2022 · 3 comments
Open

Use max_execution_time variable on zed.conf.template #688

Chemaclass opened this issue Apr 28, 2022 · 3 comments

Comments

@Chemaclass
Copy link
Contributor

Instead of using the raw-int 600, what about using @('php.fpm.ini.max_execution_time') for the other properties as well in src/spryker/docker/image/nginx/root/etc/nginx/conf.d/zed.conf.template.twig?

Simillar as we currently do for the fastcgi_read_timeout:

proxy_read_timeout 600s;
proxy_send_timeout 600s;
fastcgi_read_timeout {{ @('php.fpm.ini.max_execution_time') + 1 }}s;
client_body_timeout 600s;
client_header_timeout 600s;
send_timeout 600s;

Original idea: #685 (comment)

@kierenevans
Copy link
Contributor

Do we know what these are all doing and why? I don't see the same configuration in the non-spryker nginx configuration apart from fastcgi_read_timeout for talking to php.

@Chemaclass
Copy link
Contributor Author

Chemaclass commented Apr 28, 2022

My idea was using the php max_execution_time variable to these *_timeout settings. I don't see any problem with this.... Probably I am missing something(?)

@kierenevans
Copy link
Contributor

kierenevans commented Apr 29, 2022

Sorry I mean that I don't think we need all of those in the first place, so we have the possibility of removing some lines completely.

However upon digging into the spryker docs, the config lines are from them originally: https://docs.spryker.com/docs/scos/dev/tutorials-and-howtos/howtos/howto-install-spryker-in-aws-environment.html#nginx-configuration, so I guess we should keep them and adjust them to match the fastcgi_read_timeout

proxy_read_timeout or proxy_send_timeout don't make sense if it's not also using proxy_pass.
client_body_timeout and client_header_timeout and maybe even send_timeout probably don't matter if you have an upstream server that is buffering requests (like traefik or nginx), but I guess direct access would benefit from it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants