-
Notifications
You must be signed in to change notification settings - Fork 2.2k
fix(app): Expo Config Plugin for SDK 53 #8495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one, thank you for the fix
I rebased to current main (just in case) and did the required lint fix then re-pushed
CI should go green then can merge and will release
@mikehardy thank you. Just FYI, this PR might need to be updated again, lol: expo/expo#36441 |
@hirbod no good deed goes unpunished right? 😆 at least with regex another matcher can be added easily. That expo PR isn't merged nor released yet so I'm not sure we can take it into account really without risk of making lots of changes here that may never even be needed. However Expo 53 beta is already out, so it stands to reason that merging and releasing this now is useful and follow-ons can be made as needed |
@mikehardy I agree. Adding another matcher won’t be too bad. I’ll keep an eye on it and create a follow-up PR if needed. |
And it happened. New PR incoming |
Description
As I described here
SDK 53 initialization is failing for the core package
@react-native-firebase/app
because, as @haddad-yacine correctly pointed out, the AppDelegate.swift has changed and this regexp is failing, thus not addingFirebaseApp.configure()
.You can also see
during the prebuild phase.
The patch is pretty easily done by changing the regular expression to
I am dropping
/g
because we only need a single match to locate your insertion point.The change works as expected and remains backwards compatible.
Fixes #8494 and potentially #8461
Related issues
Release Summary
Checklist
Android
iOS
Other
(macOS, web)e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter