Skip to content

[🐛] Expo config plugin issue with SDK 53, RN 0.79 #8494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 10 tasks
hirbod opened this issue Apr 28, 2025 · 3 comments · Fixed by #8495
Closed
2 of 10 tasks

[🐛] Expo config plugin issue with SDK 53, RN 0.79 #8494

hirbod opened this issue Apr 28, 2025 · 3 comments · Fixed by #8495
Labels

Comments

@hirbod
Copy link
Contributor

hirbod commented Apr 28, 2025

Issue

Running the Expo prebuild phase with SDK 53, New Architecture, RN 79

» ios: @react-native-firebase/app: Unable to determine correct Firebase insertion point in AppDelegate.swift. Skipping Firebase addition.

Likely because the AppDelegate file changed and the config plugin fails to insert the dangerous mod correctly


Project Files

Javascript

Click To Expand

package.json:

# N/A

firebase.json for react-native-firebase v6:

# N/A

iOS

Click To Expand

ios/Podfile:

  • I'm not using Pods
  • I'm using Pods and my Podfile looks like:
# N/A

AppDelegate.m:

// N/A


Android

Click To Expand

Have you converted to AndroidX?

  • my application is an AndroidX application?
  • I am using android/gradle.settings jetifier=true for Android compatibility?
  • I am using the NPM package jetifier for react-native compatibility?

android/build.gradle:

// N/A

android/app/build.gradle:

// N/A

android/settings.gradle:

// N/A

MainApplication.java:

// N/A

AndroidManifest.xml:

<!-- N/A -->


Environment

Click To Expand

react-native info output:

 OUTPUT GOES HERE
  • Platform that you're experiencing the issue on:
    • iOS
    • Android
    • iOS but have not tested behavior on Android
    • Android but have not tested behavior on iOS
    • Both
  • react-native-firebase version you're using that has this issue:
    • e.g. 5.4.3
  • Firebase module(s) you're using that has the issue:
    • e.g. Instance ID
  • Are you using TypeScript?
    • Y/N & VERSION


@hirbod hirbod changed the title [🐛] Upgrading from 21.14.0 to 22.0.0 breaks Expo config plugin [🐛] Expo config plugin issue Apr 28, 2025
@hirbod hirbod changed the title [🐛] Expo config plugin issue [🐛] Expo config plugin issue with SDK 53, RN 0.79 Apr 28, 2025
@hirbod
Copy link
Contributor Author

hirbod commented Apr 28, 2025

Looks like there is already a PR for it #8490

@hirbod
Copy link
Contributor Author

hirbod commented Apr 28, 2025

Closing, since it's also a duplicate and a PR is up.

@hirbod hirbod closed this as completed Apr 28, 2025
@hirbod
Copy link
Contributor Author

hirbod commented Apr 28, 2025

Actually the PR #8490 does not fix the problem, I created a PR here #8495

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant