Skip to content

feat(auth, expo): add support for AppDelegate.swift #8490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025

Conversation

mgray88
Copy link
Contributor

@mgray88 mgray88 commented Apr 24, 2025

Description

With Expo SDK 53 forthcoming, they have moved to an AppDelegate.swift file. The auth Expo config plugin currently only supports an objective-c AppDelegate file. This PR adds support for the swift AppDelegate file.

Related issues

Fixes #8487

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
    • Other (macOS, web)
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan 🔥

Test results:
 PASS  packages/database/__tests__/database.test.ts
 PASS  packages/crashlytics/__tests__/crashlytics.test.ts
 PASS  packages/app-check/__tests__/appcheck.test.ts
 PASS  packages/vertexai/__tests__/stream-reader.test.ts
 PASS  packages/vertexai/__tests__/schema-builder.test.ts
 PASS  packages/remote-config/__tests__/remote-config.test.ts
 PASS  packages/vertexai/__tests__/count-tokens.test.ts
 PASS  packages/vertexai/__tests__/request.test.ts
 PASS  packages/vertexai/__tests__/chat-session.test.ts
 PASS  packages/vertexai/__tests__/generate-content.test.ts
 PASS  packages/perf/__tests__/perf.test.ts
 PASS  packages/vertexai/__tests__/generative-model.test.ts
 PASS  packages/app-check/plugin/__tests__/iosPlugin.test.ts
 PASS  packages/dynamic-links/plugin/__tests__/iosPlugin.test.ts
 PASS  packages/dynamic-links/__tests__/dynamic-links.test.ts
 PASS  packages/auth/plugin/__tests__/iosPlugin_urlTypes.test.ts
 PASS  packages/vertexai/__tests__/service.test.ts
 PASS  packages/analytics/__tests__/analytics.test.ts
 PASS  packages/ml/__tests__/ml.test.ts
 PASS  packages/app-distribution/__tests__/app-distribution.test.ts
 PASS  packages/firestore/__tests__/firestore.test.ts
 PASS  packages/storage/__tests__/storage.test.ts
 PASS  packages/messaging/plugin/__tests__/androidPlugin.test.ts
 PASS  packages/app/__tests__/app.test.ts
 PASS  packages/auth/__tests__/auth.test.ts
 PASS  packages/app-distribution/plugin/__tests__/androidPlugin.test.ts
 PASS  packages/crashlytics/plugin/__tests__/androidPlugin.test.ts
 PASS  packages/perf/plugin/__tests__/androidPlugin.test.ts
 PASS  packages/installations/__tests__/installations.test.ts
 PASS  packages/vertexai/__tests__/request-helpers.test.ts
 PASS  packages/app/plugin/__tests__/androidPlugin.test.ts
 PASS  packages/app/plugin/__tests__/iosPlugin.test.ts
 PASS  packages/in-app-messaging/__tests__/inappmessaging.test.ts
 PASS  packages/messaging/__tests__/messaging.test.ts
 PASS  packages/functions/__tests__/functions.test.ts
 PASS  packages/vertexai/__tests__/response-helpers.test.ts
 PASS  packages/vertexai/__tests__/chat-session-helpers.test.ts
 PASS  packages/vertexai/__tests__/api.test.ts
 PASS  packages/auth/plugin/__tests__/iosPlugin_openUrlFix.test.ts

Test Suites: 39 passed, 39 total
Tests:       1 skipped, 787 passed, 788 total
Snapshots:   31 passed, 31 total
Time:        4.291 s
Ran all test suites.

Think react-native-firebase is great? Please consider supporting the project with any of the below:

@CLAassistant
Copy link

CLAassistant commented Apr 24, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

vercel bot commented Apr 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2025 3:29pm

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great addition, thank you!

@mikehardy mikehardy merged commit e4966ef into invertase:main Apr 28, 2025
15 of 16 checks passed
@ivankrzak
Copy link

@mgray88
Hello,
Nice work looks like you saved me if it will be released.
Is this addition in latest 22.0.0 release ? Im being stuck at expo prebuild right now.

@a-eid
Copy link

a-eid commented May 1, 2025

@mikehardy this should be done to app-check plugin as well right ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛] 🔥 Expo SDK 53 support for auth
5 participants