feat(auth, expo): add support for AppDelegate.swift #8490
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With Expo SDK 53 forthcoming, they have moved to an AppDelegate.swift file. The auth Expo config plugin currently only supports an objective-c AppDelegate file. This PR adds support for the swift AppDelegate file.
Related issues
Fixes #8487
Release Summary
Checklist
Android
iOS
Other
(macOS, web)e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan 🔥
Test results:
PASS packages/database/__tests__/database.test.ts PASS packages/crashlytics/__tests__/crashlytics.test.ts PASS packages/app-check/__tests__/appcheck.test.ts PASS packages/vertexai/__tests__/stream-reader.test.ts PASS packages/vertexai/__tests__/schema-builder.test.ts PASS packages/remote-config/__tests__/remote-config.test.ts PASS packages/vertexai/__tests__/count-tokens.test.ts PASS packages/vertexai/__tests__/request.test.ts PASS packages/vertexai/__tests__/chat-session.test.ts PASS packages/vertexai/__tests__/generate-content.test.ts PASS packages/perf/__tests__/perf.test.ts PASS packages/vertexai/__tests__/generative-model.test.ts PASS packages/app-check/plugin/__tests__/iosPlugin.test.ts PASS packages/dynamic-links/plugin/__tests__/iosPlugin.test.ts PASS packages/dynamic-links/__tests__/dynamic-links.test.ts PASS packages/auth/plugin/__tests__/iosPlugin_urlTypes.test.ts PASS packages/vertexai/__tests__/service.test.ts PASS packages/analytics/__tests__/analytics.test.ts PASS packages/ml/__tests__/ml.test.ts PASS packages/app-distribution/__tests__/app-distribution.test.ts PASS packages/firestore/__tests__/firestore.test.ts PASS packages/storage/__tests__/storage.test.ts PASS packages/messaging/plugin/__tests__/androidPlugin.test.ts PASS packages/app/__tests__/app.test.ts PASS packages/auth/__tests__/auth.test.ts PASS packages/app-distribution/plugin/__tests__/androidPlugin.test.ts PASS packages/crashlytics/plugin/__tests__/androidPlugin.test.ts PASS packages/perf/plugin/__tests__/androidPlugin.test.ts PASS packages/installations/__tests__/installations.test.ts PASS packages/vertexai/__tests__/request-helpers.test.ts PASS packages/app/plugin/__tests__/androidPlugin.test.ts PASS packages/app/plugin/__tests__/iosPlugin.test.ts PASS packages/in-app-messaging/__tests__/inappmessaging.test.ts PASS packages/messaging/__tests__/messaging.test.ts PASS packages/functions/__tests__/functions.test.ts PASS packages/vertexai/__tests__/response-helpers.test.ts PASS packages/vertexai/__tests__/chat-session-helpers.test.ts PASS packages/vertexai/__tests__/api.test.ts PASS packages/auth/plugin/__tests__/iosPlugin_openUrlFix.test.ts Test Suites: 39 passed, 39 total Tests: 1 skipped, 787 passed, 788 total Snapshots: 31 passed, 31 total Time: 4.291 s Ran all test suites.
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter