fix(crashlytics, ios): dependencies init param removed upstream in v11+ #8025
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
firebase-ios-sdk v11+ removed one of the parameters from their component initialization API, we must remove it here to use firebase-ios-sdk v11+
Related issues
The fix for the Xcode build failures on Xcode 16+ require using firebase-ios-sdk v11+, which requires this:
Release Summary
This is a conventional commit so should be possible to rebase merge
NOTE THAT package.json needs firebase bumped to 11.2.0 as a commit before this one works - however, that is not a breaking change, if you bump package.json to 11.2.0 for firebase-ios-sdk, and merge this PR plus #8021 then react-native-firebase appears to work fine
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
tested in https://github.com/mikehardy/rnfbdemo/blob/main/make-demo.sh with a patch, a bump to firebase-ios-sdk and a patch from #8021
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter