[🐛] @react-native-firebase/firestore fails to build on Xcode 16 - BoringSSL-GRPC issue unsupported option '-G' #8020

alfjesus · 2024-09-17T08:53:41Z

Issue

Getting the following "unsupported option -G" build error when trying to build with Expo 51 and Xcode 16.
I'm guessing that the dependency for pod BoringSSL-GRPC needs an update.

Project Files

Javascript

Click To Expand

`package.json`:

# N/A

`firebase.json` for react-native-firebase v6:

# N/A

iOS

Click To Expand

`ios/Podfile`:

I'm not using Pods
I'm using Pods and my Podfile looks like:

# N/A

`AppDelegate.m`:

// N/A

Android

Click To Expand

Have you converted to AndroidX?

my application is an AndroidX application?
I am using android/gradle.settings jetifier=true for Android compatibility?
I am using the NPM package jetifier for react-native compatibility?

`android/build.gradle`:

// N/A

`android/app/build.gradle`:

// N/A

`android/settings.gradle`:

// N/A

`MainApplication.java`:

// N/A

`AndroidManifest.xml`:

<!-- N/A -->

Environment

Click To Expand

react-native info output:

 System:
  OS: macOS 15.0
  CPU: (12) arm64 Apple M2 Pro
  Memory: 465.64 MB / 32.00 GB
  Shell:
    version: "5.9"
    path: /bin/zsh
Binaries:
  Node:
    version: 20.17.0
    path: /var/folders/jn/92972fv55qdc10m6nk8nps3w0000gn/T/yarn--1726562737749-0.4741444639345749/node
  Yarn:
    version: 1.22.21
    path: /var/folders/jn/92972fv55qdc10m6nk8nps3w0000gn/T/yarn--1726562737749-0.4741444639345749/yarn
  npm:
    version: 10.8.2
    path: /opt/homebrew/opt/node@20/bin/npm
  Watchman:
    version: 2024.07.08.00
    path: /opt/homebrew/bin/watchman
Managers:
  CocoaPods:
    version: 1.15.2
    path: /opt/homebrew/bin/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 24.0
      - iOS 18.0
      - macOS 15.0
      - tvOS 18.0
      - visionOS 2.0
      - watchOS 11.0
  Android SDK: Not Found
IDEs:
  Android Studio: 2023.2 AI-232.10300.40.2321.11567975
  Xcode:
    version: 16.0/16A242d
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: 17.0.10
    path: /usr/bin/javac
  Ruby:
    version: 2.6.10
    path: /usr/bin/ruby
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 18.2.0
    wanted: 18.2.0
  react-native:
    installed: 0.74.5
    wanted: 0.74.5
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: false
iOS:
  hermesEnabled: true
  newArchEnabled: false

Platform that you're experiencing the issue on:
- iOS
- Android
- iOS but have not tested behavior on Android
- Android but have not tested behavior on iOS
- Both
react-native-firebase version you're using that has this issue:
- 20.5.0
Firebase module(s) you're using that has the issue:
- firestore
Are you using TypeScript?
- Y & 5.3.3

👉 Check out React Native Firebase and Invertase on Twitter for updates on the library.

The text was updated successfully, but these errors were encountered:

joaqo · 2024-09-17T15:51:19Z

Same here.

itsjustjo96 · 2024-09-17T16:24:00Z

Same for me. Apparently this issue was fixed in BoringSSL 0.36.

grpc/grpc#36904

itsjustjo96 · 2024-09-17T16:36:32Z

This fix indeed seems to work. Adding this code piece to the podfile and then reinstalling the pods is a temporary fix.

https://stackoverflow.com/a/78633109

alfjesus · 2024-09-17T16:39:58Z

This fix indeed seems to work. Adding this code piece to the podfile and then reinstalling the pods is a temporary fix.

https://stackoverflow.com/a/78633109

@itsjustjo96 Yes, that fix works. However, when using Expo Prebuild i.e CNG (Continuous Native Generation ), the podfile gets overwritten every time.

russellwheatley · 2024-09-17T16:45:16Z

Thank you for the workaround, @itsjustjo96 🙏 . Unfortunately, I'll be away for a week. If there is someone who is able to raise a PR in the meanwhile, I can take a look when I get back. Otherwise, I can get a fix up next week 👍

mikehardy · 2024-09-17T18:19:12Z

Upstream firebase-ios-sdk specifies a version range for the transitive gRPC dependency with the problem:

https://github.com/firebase/firebase-ios-sdk/blob/b5e2c182c83db543829f2a712f5cff7e6ad1ce1e/FirebaseFirestoreInternal.podspec#L107-L108

Here's the upstream issue firebase/firebase-ios-sdk#13115

When I do a fresh install using firebase-ios-sdk 11.2.0 it works to bring in a version of gRPC with the fix, that is a gRPC with version >= 1.65.2:

run pod install and check output, here's a snippet:

Installing gRPC-C++ (1.65.5)
Installing gRPC-Core (1.65.5)

gRPC and Firestore compile fine for me

So I do not believe this is an issue. You may need to remove your Podfile.lock and reinstall Pods to get the updated transitive dependency?

(I'm having other compile failures at the moment, notably the crashlytics init provider I worked on recently in #7837 but I will hopefully have that working shortly)

[RNFBCrashlytics] Compiling RNFBCrashlyticsInitProvider.m
❌ /Users/mike/work/invertase/rnfbdemo/rnfbdemo/node_modules/@react-native-firebase/crashlytics/ios/RNFBCrashlytics/RNFBCrashlyticsInitProvider.m:135:21: no known class method for selector 'componentWithProtocol:instantiationTiming:dependencies:creationBlock:'
  135 |       [FIRComponent componentWithProtocol:@protocol(RNFBCrashlyticsInitProviderProtocol)
      |                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

mikehardy · 2024-09-17T18:25:08Z

Note that if you are using the pre-compiled / binary Firebase from firestore-ios-sdk-frameworks they do not appear to have the fix but that is not a bug in react-native-firebase, it should be logged tracked over there.

Appears they are still on gRPC 1.65.1 which does not have the fix: https://github.com/search?q=repo%3Ainvertase%2Ffirestore-ios-sdk-frameworks+gRPC&type=code

A workaround would be to deintegrate the pre-compiled version and build firestore from current source with current transitive deps, and if compile speed is an issue you might try ccache

alfjesus · 2024-09-17T18:25:58Z

@mikehardy If I spawn up a new Expo project and add @react-native-firebase/firestore the same build failure is happening so I think this is still an issue?

mikehardy · 2024-09-17T18:27:27Z

@alfjesus I don't use Expo so I cannot comment.
I build things from scratch in order to make my assertions though, and I cannot reproduce - my build rig: https://github.com/mikehardy/rnfbdemo/blob/main/make-demo.sh

(I have local changes in that one to do the test, but it shows what I'm doing - init of bare react-native project, scripted integration of react-native-firebase, build test)

alfjesus · 2024-09-17T18:33:31Z

@mikehardy Okay I see. It's just that my Expo project was building fine on Xcode 15.4 and as soon I upgraded to Xcode 16 this build issue started to happen.

mikehardy · 2024-09-17T18:39:47Z

I believe I see the problem - just noticed that react-native-firebase hasn't adopted firebase-ios-sdk v11+ yet

It is only in firebase-ios-sdk v11+ that the gRPC version was updated, you can see the commit that did the bump and expand the tag list to see it is only SDK v11+ tags: firebase/firebase-ios-sdk@89a0ab3

My build rig specifically overrides firebase-ios-sdk in order to compile test with newer versions in order to find problems before users do, but that means it doesn't always see problems with interop in older versions

Unfortunately if you use firebase-ios-sdk v11+ via an override, you'll have a new problem which is that the crashlytics init provider API signature upstream changed and is not compatible across the firebase-ios-sdk v10 / v11 boundary

react-native-firebase/packages/crashlytics/ios/RNFBCrashlytics/RNFBCrashlyticsInitProvider.m

Line 137 in 480947e

dependencies:@[] // note this will go away in firebase-ios-sdk v11+

(with a local patch that implements #8025, and a patch that implements #8021 which I just posted, firebase-ios-sdk v11.2.0 appears to work fine with gRPC and crashlytics in build testing at least)

alfjesus · 2024-09-17T18:46:13Z

@mikehardy Nice to hear that you have nailed down the root cause of the issue. Hopefully react-native-firebase can be adotped soon to use firebase-ios-sdk v11+. I believe that the number of users impacted by this issue will increase by every day that passed by when people upgrade to Xcode 16, unaware of this issue. Rollback is also not so easy since after upgrading to Xcode 16 on MacOS Sequoia, you can't roll back to Xcode 15.4.

alfjesus · 2024-09-17T21:04:02Z

Figured out a temporary patch to adopt in firebase-ios-sdk v11+. Builds successfully after patching.

Attaching the patch files
@react-native-firebase+firestore+20.5.0.patch
@react-native-firebase+app+20.5.0.patch

mikehardy · 2024-09-17T21:48:47Z

If you need crashlytics and firebase-ios-sdk v11+ you'll also want this:

diff --git a/node_modules/@react-native-firebase/crashlytics/ios/RNFBCrashlytics/RNFBCrashlyticsInitProvider.m b/node_modules/@react-native-firebase/crashlytics/ios/RNFBCrashlytics/RNFBCrashlyticsInitProvider.m
index b815df9..4e4961d 100644
--- a/node_modules/@react-native-firebase/crashlytics/ios/RNFBCrashlytics/RNFBCrashlyticsInitProvider.m
+++ b/node_modules/@react-native-firebase/crashlytics/ios/RNFBCrashlytics/RNFBCrashlyticsInitProvider.m
@@ -134,7 +134,6 @@ NSString *const KEY_CRASHLYTICS_JAVASCRIPT_EXCEPTION_HANDLER_CHAINING_ENABLED =
   FIRComponent *crashlyticsInitProvider =
       [FIRComponent componentWithProtocol:@protocol(RNFBCrashlyticsInitProviderProtocol)
                       instantiationTiming:FIRInstantiationTimingEagerInDefaultApp
-                             dependencies:@[]  // note this will go away in firebase-ios-sdk v11+
                             creationBlock:creationBlock];
 
   return @[ crashlyticsInitProvider ];

(I have it as patches/@react-native-firebase+crashlytics+20.5.0.patch) --> https://github.com/mikehardy/rnfbdemo/blob/main/patches/%40react-native-firebase%2Bcrashlytics%2B20.5.0.patch

oskaremilsson · 2024-09-18T07:37:15Z

Thank you! 🙏 I just want to confirm that with these 3 patches our Expo-project now builds again. 🎉

mikehardy · 2024-09-18T13:40:58Z

Hey everyone! 👋

+1s, reports that it is also affecting you: that does not help
it really makes the issue hard to read for others that want a workaround

The workaround right now is to patch react-native-firebase with the above patches:

one to bump firebase-ios-sdk to 11.2.0,
one to fix firestore
optional one to fix crashlytics build if you use crashlytics

And then we have to wait for an official release

If you subscribe to this issue using the button on the right of the github web UI you will be notified when it is closed so you know there is new information

Until then, we all have to use the patches or wait for a release.

terrafant · 2024-09-18T16:15:00Z

This fix indeed seems to work. Adding this code piece to the podfile and then reinstalling the pods is a temporary fix.

https://stackoverflow.com/a/78633109

For Expo project this solution works for me:

Add withBoringSSLFix.js to the root of the project:

// withBoringSSLFix.js

const { withDangerousMod } = require('@expo/config-plugins');
const fs = require('fs');
const path = require('path');

const withBoringSSLFix = (config) => {
  return withDangerousMod(config, [
    'ios',
    (config) => {
      const podfilePath = path.join(config.modRequest.platformProjectRoot, 'Podfile');
      let podfileContents = fs.readFileSync(podfilePath, 'utf-8');

      //  Fix for the Podfile
      const fix = `
  pre_install do |installer|
    installer.pod_targets.each do |pod|
      if pod.name.eql?('BoringSSL-GRPC')
        def pod.build_type;
          Pod::BuildType.static_library
        end
      end
    end
  end
`;

      // Adding the fix before the first 'post_install' occurrence
      if (!podfileContents.includes("pod.name.eql?('BoringSSL-GRPC')")) {
        const postInstallIndex = podfileContents.indexOf('post_install do |installer|');
        if (postInstallIndex !== -1) {
          podfileContents = podfileContents.slice(0, postInstallIndex) + fix + podfileContents.slice(postInstallIndex);
        } else {
          // If there's no post_install, append the fix at the end
          podfileContents += fix;
        }
        fs.writeFileSync(podfilePath, podfileContents);
      }

      return config;
    },
  ]);
};

module.exports = withBoringSSLFix;

Update app.config.js (or if you don't have app.config.js, then convert app.json to app.config.js):

import withBoringSSLFix from './withBoringSSLFix';

export default {
  expo: {
    //... expo configs
     plugins: [
  // ... other existing plugins
  withBoringSSLFix,
   ]}
}

Regenerate the native iOS project
npx expo prebuild -p ios --clean
Run iOS project:
npx expo run:ios

alfjesus · 2024-09-18T16:21:38Z

This fix indeed seems to work. Adding this code piece to the podfile and then reinstalling the pods is a temporary fix.
https://stackoverflow.com/a/78633109

For Expo project this solution works for me:

Add withBoringSSLFix.js to the root of the project:

// withBoringSSLFix.js

const { withDangerousMod } = require('@expo/config-plugins');
const fs = require('fs');
const path = require('path');

const withBoringSSLFix = (config) => {
  return withDangerousMod(config, [
    'ios',
    (config) => {
      const podfilePath = path.join(config.modRequest.platformProjectRoot, 'Podfile');
      let podfileContents = fs.readFileSync(podfilePath, 'utf-8');

      //  Fix for the Podfile
      const fix = `
  pre_install do |installer|
    installer.pod_targets.each do |pod|
      if pod.name.eql?('BoringSSL-GRPC')
        def pod.build_type;
          Pod::BuildType.static_library
        end
      end
    end
  end
`;

      // Adding the fix before the first 'post_install' occurrence
      if (!podfileContents.includes("pod.name.eql?('BoringSSL-GRPC')")) {
        const postInstallIndex = podfileContents.indexOf('post_install do |installer|');
        if (postInstallIndex !== -1) {
          podfileContents = podfileContents.slice(0, postInstallIndex) + fix + podfileContents.slice(postInstallIndex);
        } else {
          // If there's no post_install, append the fix at the end
          podfileContents += fix;
        }
        fs.writeFileSync(podfilePath, podfileContents);
      }

      return config;
    },
  ]);
};

module.exports = withBoringSSLFix;

Update app.config.js (or if you don't have app.config.js, then convert app.json to app.config.js):

import withBoringSSLFix from './withBoringSSLFix';

export default {
  expo: {
    //... expo configs
     plugins: [
  // ... other existing plugins
  withBoringSSLFix,
   ]}
}

Regenerate the native iOS project
npx expo prebuild -p ios --clean
Run iOS project:
npx expo run:ios

This fix indeed seems to work. Adding this code piece to the podfile and then reinstalling the pods is a temporary fix.
https://stackoverflow.com/a/78633109

For Expo project this solution works for me:

Add withBoringSSLFix.js to the root of the project:

// withBoringSSLFix.js

const { withDangerousMod } = require('@expo/config-plugins');
const fs = require('fs');
const path = require('path');

const withBoringSSLFix = (config) => {
  return withDangerousMod(config, [
    'ios',
    (config) => {
      const podfilePath = path.join(config.modRequest.platformProjectRoot, 'Podfile');
      let podfileContents = fs.readFileSync(podfilePath, 'utf-8');

      //  Fix for the Podfile
      const fix = `
  pre_install do |installer|
    installer.pod_targets.each do |pod|
      if pod.name.eql?('BoringSSL-GRPC')
        def pod.build_type;
          Pod::BuildType.static_library
        end
      end
    end
  end
`;

      // Adding the fix before the first 'post_install' occurrence
      if (!podfileContents.includes("pod.name.eql?('BoringSSL-GRPC')")) {
        const postInstallIndex = podfileContents.indexOf('post_install do |installer|');
        if (postInstallIndex !== -1) {
          podfileContents = podfileContents.slice(0, postInstallIndex) + fix + podfileContents.slice(postInstallIndex);
        } else {
          // If there's no post_install, append the fix at the end
          podfileContents += fix;
        }
        fs.writeFileSync(podfilePath, podfileContents);
      }

      return config;
    },
  ]);
};

module.exports = withBoringSSLFix;

Update app.config.js (or if you don't have app.config.js, then convert app.json to app.config.js):

import withBoringSSLFix from './withBoringSSLFix';

export default {
  expo: {
    //... expo configs
     plugins: [
  // ... other existing plugins
  withBoringSSLFix,
   ]}
}

Regenerate the native iOS project
npx expo prebuild -p ios --clean
Run iOS project:
npx expo run:ios

@terrafant Even though your fix works, I don't understand why this option is preferable compared to patches? I mean once a new version of react-native-firebase is out, you will need to modify app.config.js again to remove the fix. A patch on the other hand is only bound and applied to a specific version, hence no code change is necessary when a new release is out.

terrafant · 2024-09-18T16:34:08Z

@alfjesus because this way I don't have to reapply patches again if I need to redo npm install

alfjesus · 2024-09-18T16:38:11Z

@alfjesus because this way I don't have to reapply patches again if I need to redo npm install

https://github.com/ds300/patch-package to the rescue! This is want I use. Applies patches automatically every time you do npm install

mikehardy · 2024-09-18T16:50:43Z

It may be that adopting new versions requires some sort of coordination / certification process for users such that even a release of react-native-firebase does not really help them quickly as someone may not be able to adopt it, and patches may not be allowed for certification reasons too 🤷 .

So I appreciate the Expo plugin workaround from @terrafant even if I also personally use + love the patch-package module.

You never know which workaround people will need.

I believe the fixes required to adopt firebase-ios-sdk v11+ are in process though and there will be a release soon.

Until then, patch it, do a plugin, whichever works but hopefully everyone is able to continue working despite the yearly disruption that is the Xcode release day :-)

PavelShev · 2024-09-18T19:00:02Z

same here. ReactNative CLI
Edit the Podfile, and the project started build like a charm

post_install do |installer|
    installer.pods_project.targets.each do |target|
      if target.name == 'BoringSSL-GRPC'
        target.source_build_phase.files.each do |file|
          if file.settings && file.settings['COMPILER_FLAGS']
            flags = file.settings['COMPILER_FLAGS'].split
            flags.reject! { |flag| flag == '-GCC_WARN_INHIBIT_ALL_WARNINGS' }
            file.settings['COMPILER_FLAGS'] = flags.join(' ')
          end
        end
      end
    end
    $RNMapboxMaps.post_install(installer)
    # https://github.com/facebook/react-native/blob/main/packages/react-native/scripts/react_native_pods.rb#L197-L202
    react_native_post_install(
      installer,
      config[:reactNativePath],
      :mac_catalyst_enabled => false,
      # :ccache_enabled => true
    )
  end
end

alfjesus added Needs Attention type: bug New bug report labels Sep 17, 2024

mikehardy mentioned this issue Sep 17, 2024

[🐛] 🔥 Xcode 16.0 fails to build 20.5.0 #8019

Closed

9 tasks

mikehardy changed the title ~~[🐛] @react-native-firebase/firestore fails to build on Xcode 16 - BoringSSL-GRPC issue~~ [🐛] @react-native-firebase/firestore fails to build on Xcode 16 - BoringSSL-GRPC issue unsupported option '-G' Sep 17, 2024

This comment was marked as resolved.

Sign in to view

This comment was marked as duplicate.

Sign in to view

tibbe mentioned this issue Sep 18, 2024

Fails to build on Xcode 16 mockingbot/react-native-zip-archive#316

Open

This comment was marked as duplicate.

Sign in to view

mikehardy mentioned this issue Sep 18, 2024

fix(crashlytics, ios): dependencies init param removed upstream in v11+ #8025

Merged

8 tasks

[🐛] @react-native-firebase/firestore fails to build on Xcode 16 - BoringSSL-GRPC issue unsupported option '-G' #8020

[🐛] @react-native-firebase/firestore fails to build on Xcode 16 - BoringSSL-GRPC issue unsupported option '-G' #8020

Comments

alfjesus commented Sep 17, 2024 • edited by mikehardy Loading

Issue

Project Files

Javascript

package.json:

firebase.json for react-native-firebase v6:

iOS

ios/Podfile:

AppDelegate.m:

Android

Have you converted to AndroidX?

android/build.gradle:

android/app/build.gradle:

android/settings.gradle:

MainApplication.java:

AndroidManifest.xml:

Environment

joaqo commented Sep 17, 2024

itsjustjo96 commented Sep 17, 2024

itsjustjo96 commented Sep 17, 2024

alfjesus commented Sep 17, 2024

russellwheatley commented Sep 17, 2024

mikehardy commented Sep 17, 2024 • edited Loading

mikehardy commented Sep 17, 2024

alfjesus commented Sep 17, 2024

mikehardy commented Sep 17, 2024

alfjesus commented Sep 17, 2024

mikehardy commented Sep 17, 2024 • edited Loading

alfjesus commented Sep 17, 2024

alfjesus commented Sep 17, 2024

mikehardy commented Sep 17, 2024

oskaremilsson commented Sep 18, 2024

This comment was marked as resolved.

This comment was marked as duplicate.

This comment was marked as duplicate.

mikehardy commented Sep 18, 2024 • edited Loading

terrafant commented Sep 18, 2024 • edited Loading

alfjesus commented Sep 18, 2024

terrafant commented Sep 18, 2024

alfjesus commented Sep 18, 2024

mikehardy commented Sep 18, 2024 • edited Loading

PavelShev commented Sep 18, 2024 • edited Loading

alfjesus commented Sep 17, 2024 •

edited by mikehardy

Loading

`package.json`:

`firebase.json` for react-native-firebase v6:

`ios/Podfile`:

`AppDelegate.m`:

`android/build.gradle`:

`android/app/build.gradle`:

`android/settings.gradle`:

`MainApplication.java`:

`AndroidManifest.xml`:

mikehardy commented Sep 17, 2024 •

edited

Loading

mikehardy commented Sep 17, 2024 •

edited

Loading

mikehardy commented Sep 18, 2024 •

edited

Loading

terrafant commented Sep 18, 2024 •

edited

Loading

mikehardy commented Sep 18, 2024 •

edited

Loading

PavelShev commented Sep 18, 2024 •

edited

Loading