fix backward feature selection for fixed_steps #34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backward feature selection has some issues, namely:
@jonathan-taylor do you mind taking a review here? only tried to fix the
fixed_steps
case, but I imaginefirst_peak
has the same issue as well.Love the ISLP library and book by the way! I just found this issue while going through the exercises in chapter 6, 8.d was not possible to do with the current package. LMK if the fix looks good :)