-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oneMKL migration: Fix for DLL loading issue on Windows #2063
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Vika-F please provide the link to the job with your branch and oneapi-src/oneDAL#2756.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Vika-F Thank you for the work done!
No objections from my side.
Before to approve let me ask: is this one of the options or agreed fix for OneMKL issues on sklearnex side?
Expect that test fails covered by #2066 deselections |
@samir-nasibli yes, those changes were agreed with @napetrov and @syakov-intel . |
…ipt (intel#2063) * oneMKL migration: Fix for DLL loading issue on Windows
…25.0 release branch (#2070) * oneMKL migration: Temporary deselection of tests (#2066) * Temporary deselection of tests that started to fail after oneMKL migration * Moved deseletions for 'onedal' and 'sklearnex' modules directly into test codes * minor change * Replace TODO notes with pytest.skip * Deselect test_naive_bayes and test_naive_bayes_streaming in daal4py TestExCSRMatrix * DEV: Add path to tbb*.dll into environment in daal4py module init script (#2063) * oneMKL migration: Fix for DLL loading issue on Windows
__init__.py
file indaal4py
module was modified to add paths to TBB DLLs into the process environment in caseTBBROOT
environment variable is available.This work is related to oneDAL PR #2756.
Checklist to comply with before moving PR from draft:
PR completeness and readability
Testing
Performance