Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oneMKL migration: Cherry-picking commits from #2063 and #2066 into 2025.0 release branch #2070

Merged
merged 2 commits into from
Oct 3, 2024
Merged

oneMKL migration: Cherry-picking commits from #2063 and #2066 into 2025.0 release branch #2070

merged 2 commits into from
Oct 3, 2024

Conversation

Vika-F
Copy link
Contributor

@Vika-F Vika-F commented Sep 26, 2024 •
edited
Loading

Cherry-picking commits from #2063 and #2066 into 2025.0 release branch.

Checklist to comply with before moving PR from draft:

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • The unit tests pass successfully.
  • I have run it locally and tested the changes extensively.

Performance

  • I have measured performance for affected algorithms using scikit-learn_bench and provided at least summary table with measured data, if performance change is expected.
  • I have provided justification why performance has changed or why changes are not expected.

@Vika-F
oneMKL migration: Temporary deselection of tests (intel#2066)
aac11fb 
* Temporary deselection of tests that started to fail after oneMKL migration

* Moved deseletions for 'onedal' and 'sklearnex' modules directly into test codes

* minor change

* Replace TODO notes with pytest.skip

* Deselect test_naive_bayes and test_naive_bayes_streaming in daal4py TestExCSRMatrix
@Vika-F
DEV: Add path to tbb*.dll into environment in daal4py module init scr…
096086d 
…ipt (intel#2063)

* oneMKL migration: Fix for DLL loading issue on Windows
@Vika-F Vika-F added the testing Tests for sklearnex/daal4py/onedal4py & patching sklearn label Sep 26, 2024
@Vika-F Vika-F changed the base branch from main to rls/2025.0.0-rls September 26, 2024 09:55
@samir-nasibli
Copy link
Contributor

@Vika-F before the merge do we need to validate this with CI?

@napetrov napetrov merged commit ae8edf3 into intel:rls/2025.0.0-rls Oct 3, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samir-nasibli samir-nasibli samir-nasibli approved these changes

@napetrov napetrov napetrov approved these changes

@Alexsandruss Alexsandruss Awaiting requested review from Alexsandruss Alexsandruss is a code owner

@homksei homksei Awaiting requested review from homksei

@ahuber21 ahuber21 Awaiting requested review from ahuber21

@ethanglaser ethanglaser Awaiting requested review from ethanglaser

Assignees
No one assigned
Labels
testing Tests for sklearnex/daal4py/onedal4py & patching sklearn
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Vika-F @samir-nasibli @napetrov