Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved port already exists error message with module name #526

Merged
merged 1 commit into from
Oct 5, 2024

Conversation

c0d3-br3ak9r
Copy link
Contributor

Description & Motivation

It is difficult to debug and identify from where (which module) UnavailableReservedNameException is getting thrown

Related Issue(s)

Fixes #521

Testing

Added duplicate port names in example files and verified that the exception message includes the module name

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

NA

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

NA

Copy link
Contributor

@mkorbel1 mkorbel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for your contribution!

@mkorbel1 mkorbel1 merged commit 4131bcd into intel:main Oct 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve error message for when a port already exists on a module
2 participants