Fixes for LogicValue operation bugs related to size, sign, math, and comparison #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe update your Related Issue to verb Fix to allow auto close of issue 299 once the pull request being merged. E.g. Related issue(s)Fix #299 |
mkorbel1
requested changes
Mar 27, 2023
|
I made a one-line change that fixes the original test. I haven't made tests for the other observations on the 64-bit boundary, |
mkorbel1
requested changes
Sep 13, 2023
mkorbel1
changed the title
mkorbel1
reviewed
Sep 13, 2023
mkorbel1
reviewed
Sep 14, 2023
mkorbel1
requested changes
Sep 16, 2023
mkorbel1
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & Motivation
Adds two tests for wide bitvector comparisons. Adds a fix for one of them.
The remaining problem is that shifting a 1 into the signed position and then converting to bigint results in a negative number regardless.
Related Issue(s)
Fix #299
Testing
Created two tests that do comparisons. One just breaks the length check. The other puts a 1 in the sign location just before conversion to BigInt (the fix for the first).
Backwards-compatibility
The change is in the core logic comparison operation so more tests may be needed.
Documentation
No