Fixed null check and default case

intel · Aug 1, 2023 · def7a8a · def7a8a
1 parent 14cfea9
commit def7a8a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/lib/src/exceptions/logic/signal_width_mismatch_exception.dart b/lib/src/exceptions/logic/signal_width_mismatch_exception.dart
@@ -30,6 +30,6 @@ class SignalWidthMismatchException extends RohdException {
   /// Constructs a new [Exception] for when a dynamic has no width or it could
   /// not be inferred.
   SignalWidthMismatchException.forNull(dynamic val)
-      : super('Could not infer width of value $val.'
+      : super('Could not infer width of input $val.'
             ' Please provide a valid width.');
 }
diff --git a/lib/src/modules/conditional.dart b/lib/src/modules/conditional.dart
@@ -923,16 +923,16 @@ Logic cases(Logic expression, Map<dynamic, dynamic> conditions,
 
     width ??= inferredWidth;
 
-    if (width == null && inferredWidth == null) {
-      throw SignalWidthMismatchException.forNull(conditionValue);
-    }
-
     if (width != inferredWidth && inferredWidth != null) {
       throw SignalWidthMismatchException.forDynamic(
           conditionValue, width!, inferredWidth);
     }
   }
 
+  if (width == null) {
+    throw SignalWidthMismatchException.forNull(conditions);
+  }
+
   for (final condition in conditions.entries) {
     if (condition.key is Logic) {
       if (expression.width != (condition.key as Logic).width) {
@@ -963,7 +963,7 @@ Logic cases(Logic expression, Map<dynamic, dynamic> conditions,
                 [result < condition.value])
         ],
         conditionalType: conditionalType,
-        defaultItem: defaultValue != null ? [result < defaultValue] : [])
+        defaultItem: defaultValue != null ? [result < defaultValue] : null)
   ]);
 
   return result;