Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSC 2D prefetch: Unify type of dummy data arg to i32 #940

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

silee2
Copy link
Contributor

@silee2 silee2 commented Oct 23, 2024

since the generated intinrsic call is independent of dummy data arg type. Type mismatch error happens if multiple callers use different types for dummy data arg.
For non 32bit element type, normalize 2D prefetch shape around i32 data type. Inner dimension gets scaled according to ratio between 32 and bitwidth of element type
Add mixed type 2D prefetch test case.

Please review these guidelines to help with the review process:

  • Have you provided a meaningful PR description?
  • Have you added a test, a reproducer, or a reference to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?
  • Have you organized your commits logically and ensured each can be built by itself?

the generated intinrsic call is independent of dummy data arg type.
Type mismatch error happens if multiple callers use different types
for dummy data arg.
For non 32bit element type, normalize 2D prefetch shape around i32
data type. Inner dimension gets scaled according to ratio between
32 and bitwidth of element type
Add mixed type 2D prefetch test case.
@silee2 silee2 requested review from Garra1980 and mshahneo October 23, 2024 19:08
Copy link
Contributor

@mshahneo mshahneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silee2 silee2 merged commit 52cadab into intel:main Oct 23, 2024
2 checks passed
@silee2 silee2 deleted the fix2DPrefetchDummyDataArg_for_upstream branch October 23, 2024 19:38
silee2 added a commit to silee2/mlir-extensions that referenced this pull request Oct 31, 2024
…last suffix.

Revert "LSC 2D prefetch: Unify type of dummy data arg to i32 (intel#940)"
silee2 added a commit that referenced this pull request Oct 31, 2024
#949)

Prefetch 2D: encode dummy data type as part of intrinsic name as the last suffix.
Revert "LSC 2D prefetch: Unify type of dummy data arg to i32 (#940)"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants