Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefetch 2D: encode dummy data type as part of intrinsic name as the … #949

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Prefetch 2D: encode dummy data type as part of intrinsic name as the … #949

merged 1 commit into from
Oct 31, 2024

Conversation

silee2
Copy link
Contributor

@silee2 silee2 commented Oct 31, 2024

…last suffix.

Revert "LSC 2D prefetch: Unify type of dummy data arg to i32 (#940)"

Please review these guidelines to help with the review process:

  • Have you provided a meaningful PR description?
  • Have you added a test, a reproducer, or a reference to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?
  • Have you organized your commits logically and ensured each can be built by itself?

@silee2
Prefetch 2D: encode dummy data type as part of intrinsic name as the …
143bd4d 
…last suffix.

Revert "LSC 2D prefetch: Unify type of dummy data arg to i32 (intel#940)"
@silee2 silee2 requested review from Garra1980 and mshahneo October 31, 2024 19:41
mshahneo
mshahneo approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@mshahneo mshahneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silee2 silee2 merged commit 3b8c2af into intel:main Oct 31, 2024
2 checks passed
@silee2 silee2 deleted the fix2DPrefetch_for_upstream branch October 31, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshahneo mshahneo mshahneo approved these changes

@Garra1980 Garra1980 Awaiting requested review from Garra1980

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@silee2 @mshahneo