Unlock mutex before return #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dylan-debug
approved these changes
Jul 25, 2023
XinfengZhang
approved these changes
Jul 25, 2023
dvrogozh
requested changes
Jul 25, 2023
va/va_trace.c
Outdated
|
|
||
| TRACE_FUNCNAME(idx); | ||
|
|
||
| va_TraceMsg(trace_ctx, "\tsurfaceId = 0x%08x\n", surfaceId); |
There was a problem hiding this comment.
I liked that these 3 items would be printed regardless of memType check.... Consider that someone will need to extend this function to cover other mem types - he will need to basically revert your change.
Thus, please, revert back the change and handle mutex issue in a different way, i.e. either call DPY2TRACE_VIRCTX_EXIT before each return or use goto exit instead of return.
Always release mutex before return. Signed-off-by: Jay Yang <[email protected]>
MicroYY
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always release mutex before return.
Signed-off-by: Jay Yang [email protected]