Adjust code order to avoid mutex not released

Check parameter first to make sure mutex isn't acquired before return. Signed-off-by: Jay Yang <[email protected]>
intel · Jul 25, 2023 · 1faee23 · 1faee23
1 parent 8155a20
commit 1faee23
Showing 1 changed file with 10 additions and 10 deletions.
diff --git a/va/va_trace.c b/va/va_trace.c
@@ -6324,16 +6324,6 @@ void va_TraceExportSurfaceHandle(
     uint32_t         flags,
     void             *descriptor)
 {
-    int i;
-
-    DPY2TRACE_VIRCTX(dpy);
-
-    TRACE_FUNCNAME(idx);
-
-    va_TraceMsg(trace_ctx, "\tsurfaceId = 0x%08x\n", surfaceId);
-    va_TraceMsg(trace_ctx, "\tmemType   = 0x%08x\n", memType);
-    va_TraceMsg(trace_ctx, "\tflags     = 0x%08x\n", flags);
-
     if (memType != VA_SURFACE_ATTRIB_MEM_TYPE_DRM_PRIME_2) {
         return;
     }
@@ -6344,6 +6334,16 @@ void va_TraceExportSurfaceHandle(
         return;
     }
 
+    int i;
+
+    DPY2TRACE_VIRCTX(dpy);
+
+    TRACE_FUNCNAME(idx);
+
+    va_TraceMsg(trace_ctx, "\tsurfaceId = 0x%08x\n", surfaceId);
+    va_TraceMsg(trace_ctx, "\tmemType   = 0x%08x\n", memType);
+    va_TraceMsg(trace_ctx, "\tflags     = 0x%08x\n", flags);
+
     va_TraceMsg(trace_ctx, "\tfourcc      = %u\n", desc->fourcc);
     va_TraceMsg(trace_ctx, "\twidth       = %u\n", desc->width);
     va_TraceMsg(trace_ctx, "\theight      = %u\n", desc->height);