Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

va: Fix -Wl,--version-script check with LLD 17 #732

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vimproved
Copy link

In the upcoming LLD 17 (and previously in LLD 16.0.0, but reverted in 16.0.1), --no-undefined-version is becoming the default behavior. This causes the configure check for --version-scripts support to fail due to the symbols in the version script not being defined, which will cause the version script to not be used, and the build will fail due to --no-undefined-version. This commit adds '-Wl,--undefined-version' to the args of the configure check.

vimproved added a commit to vimproved/gentoo that referenced this pull request Jul 20, 2023
Upstream PR: intel/libva#732

In the upcoming LLD 17 (and previously in LLD 16.0.0, but reverted in 16.0.1), --no-undefined-version is becoming the default behavior. This causes the configure check for --version-scripts support to fail due to the symbols in the version script not being defined, which will cause the version script to not be used, and the build will fail due to --no-undefined-version. This patch adds '-Wl,--undefined-version' to the args of the configure check.

Signed-off-by: Violet Purcell <[email protected]>
vimproved added a commit to vimproved/gentoo that referenced this pull request Jul 20, 2023
Upstream PR: intel/libva#732

In the upcoming LLD 17 (and previously in LLD 16.0.0, but reverted in 16.0.1),
--no-undefined-version is becoming the default behavior. This causes the
configure check for --version-scripts support to fail due to the symbols in
the version script not being defined, which will cause the version script to
not be used, and the build will fail due to --no-undefined-version. This patch
adds '-Wl,--undefined-version' to the args of the configure check.

Signed-off-by: Violet Purcell <[email protected]>
@XinfengZhang
Copy link
Contributor

@vimproved , could you help to address the action issue?

@vimproved
Copy link
Author

@vimproved , could you help to address the action issue?

Yes, sorry. I've been meaning to look at this for a while now, since I think this PR is not the best approach.

LLD 17 uses --no-undefined-version by default, so the check currently
fails due to vaCreateSurface being undefined. This commit replaces that
check with a generic check in the top level meson.build, using the
conftest.syms file.

Signed-off-by: Violet Purcell <[email protected]>
@vimproved vimproved changed the title va: fix configure check for --version-script with --no-undefined-version va: Fix -Wl,--version-script check with LLD 17 Oct 1, 2023
@vimproved
Copy link
Author

Updated this PR with a different method of fixing that should be more correct.

vimproved added a commit to vimproved/gentoo that referenced this pull request Oct 12, 2023
Upstream-PR: intel/libva#732

Signed-off-by: Violet Purcell <[email protected]>
vimproved added a commit to vimproved/gentoo that referenced this pull request Oct 12, 2023
Upstream-PR: intel/libva#732
Signed-off-by: Violet Purcell <[email protected]>
nvinson added a commit to nvinson/gentoo that referenced this pull request Jan 15, 2024
Backport proposed upstream patch from
intel/libva#732

Fixes Gentoo bug: 919505 ( https://bugs.gentoo.org/919505 )

Signed-off-by: Nicholas Vinson <[email protected]>
nvinson added a commit to nvinson/gentoo that referenced this pull request Jan 15, 2024
Backport proposed upstream patch from
intel/libva#732

Bug: 919505

Signed-off-by: Nicholas Vinson <[email protected]>
nvinson added a commit to nvinson/gentoo that referenced this pull request Jan 15, 2024
Backport proposed upstream patch from
intel/libva#732

Bug: https://bugs.gentoo.org/919505

Signed-off-by: Nicholas Vinson <[email protected]>
gentoo-bot pushed a commit to gentoo/gentoo that referenced this pull request Jan 17, 2024
Backport proposed upstream patch from
intel/libva#732

Bug: https://bugs.gentoo.org/919505
Signed-off-by: Nicholas Vinson <[email protected]>
Closes: #34818
Signed-off-by: Sam James <[email protected]>
gentoo-bot pushed a commit to gentoo/gentoo that referenced this pull request May 6, 2024
Upstream-PR: intel/libva#732
Closes: https://bugs.gentoo.org/915200
Closes: #33314
Signed-off-by: Violet Purcell <[email protected]>
Signed-off-by: Matt Turner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants