Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

va/Android.mk: Fixes for compilation #728

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

va/Android.mk: Fixes for compilation #728

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c6568e
va/Android.mk: define SYSCONFDIR
muhammad23012009 Jul 9, 2023
63e2f37
va/Android.mk: Install libraries in /system instead
muhammad23012009 Jul 9, 2023
75159d5
va/Android.mk: don't build libva{_android} as proprietary module
muhammad23012009 Jul 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions va/Android.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@

LOCAL_PATH:= $(call my-dir)

LIBVA_DRIVERS_PATH_32 := /vendor/lib/dri
LIBVA_DRIVERS_PATH_64 := /vendor/lib64/dri
LIBVA_DRIVERS_PATH_32 := /system/lib/dri
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libva should be put at vendor partition since system partition is for android AOSP and can be updated seperately with vendor partition.

LIBVA_DRIVERS_PATH_64 := /system/lib64/dri

include $(CLEAR_VARS)

Expand All @@ -51,14 +51,14 @@ LOCAL_CFLAGS_64 += \

LOCAL_CFLAGS := \
$(IGNORED_WARNNING) \
-DSYSCONFDIR=\"/system/etc\" \
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be put at /vendor/etc/

-DLOG_TAG=\"libva\"

LOCAL_C_INCLUDES := $(LOCAL_PATH)/..

LOCAL_MODULE_TAGS := optional
LOCAL_MODULE := libva
LOCAL_MODULE_CLASS := SHARED_LIBRARIES
LOCAL_PROPRIETARY_MODULE := true

LOCAL_SHARED_LIBRARIES := libdl libdrm libcutils liblog

Expand Down Expand Up @@ -95,7 +95,6 @@ LOCAL_C_INCLUDES += \

LOCAL_MODULE_TAGS := optional
LOCAL_MODULE := libva-android
LOCAL_PROPRIETARY_MODULE := true

LOCAL_SHARED_LIBRARIES := libva libdrm liblog

Expand Down