Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

va/Android.mk: Fixes for compilation #728

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

muhammad23012009
Copy link

No description provided.

* defined to /system/etc by default, since anyone building libva-android can install a configuration file there.
* These libraries aren't exactly supposed to end up in /vendor, https://source.android.com/docs/core/architecture/vndk defined here. Only vendor specific items are supposed to be in /vendor.
* Allows libva-utils to compile with libva-android as well
@@ -25,8 +25,8 @@

LOCAL_PATH:= $(call my-dir)

LIBVA_DRIVERS_PATH_32 := /vendor/lib/dri
LIBVA_DRIVERS_PATH_64 := /vendor/lib64/dri
LIBVA_DRIVERS_PATH_32 := /system/lib/dri

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libva should be put at vendor partition since system partition is for android AOSP and can be updated seperately with vendor partition.

Copy link

@xmao4-intel xmao4-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libva is a vendor specified module and should be in vendor partition.

@@ -51,14 +51,14 @@ LOCAL_CFLAGS_64 += \

LOCAL_CFLAGS := \
$(IGNORED_WARNNING) \
-DSYSCONFDIR=\"/system/etc\" \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be put at /vendor/etc/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants