Skip to content

raise error if token count exceeds 1024 instead of attempting to re-chunk #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 18, 2025
Merged

raise error if token count exceeds 1024 instead of attempting to re-chunk #29

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
961dbd2
raise error if token count exceeds 1024 instead of attempting to re-c…
khaledsulayman Jun 10, 2025
85999ee
when chunk exceeds max token count, print truncated chunk
khaledsulayman Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 14 additions & 16 deletions notebooks/instructlab-knowledge/utils/create_seed_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ def safe_concatenate_datasets(datasets: list[Dataset]) -> Dataset:
def get_token_count(text, tokenizer):
return len(tokenizer.tokenize(text))

def add_icls(qna_yaml: Dict[str, str], chunked_document: Dataset) -> Dataset:
def add_icls(qna_yaml: Dict[str, str], chunked_document: Dataset, max_token_count: int = 1024) -> Dataset:
"""
Add the ICLS label to the dataset.
Args:
Expand Down Expand Up @@ -147,24 +147,22 @@ def add_icls(qna_yaml: Dict[str, str], chunked_document: Dataset) -> Dataset:
)
)
chunked_document_all_icl = safe_concatenate_datasets(chunked_document_all_icl)
chunked_document_all_icl = chunked_document_all_icl.map(
lambda x: {
"chunks": chunk_document(
[x["document"]], server_ctx_size=4096, chunk_word_count=1024
)
if get_token_count(x["document"], tokenizer) > 1024
else [x["document"]]
}
)
def truncate_chunk(chunk: str):
words = chunk.split()
if len(words) > 7:
return " ".join(words[:3]) + " ... " + " ".join(words[-3:])
return chunk

for c in chunked_document_all_icl:
if get_token_count(c["document"], tokenizer) > max_token_count:
raise ValueError(f"Chunk \"{truncate_chunk(c["document"])}\" exceeds token count of {max_token_count}")


df = chunked_document_all_icl.to_pandas()
df_exploded = df.explode("chunks").reset_index(drop=True)
new_ds = Dataset.from_pandas(df_exploded)
new_ds = new_ds.remove_columns("document").rename_columns(
{"chunks": "document"}
)
new_ds = Dataset.from_pandas(df)

# Only keep document greater than 100 tokens
new_ds = new_ds.filter(
lambda x: get_token_count(x["document"], tokenizer) > 100
lambda c: get_token_count(c["document"], tokenizer) > 100
)
return new_ds