raise error if token count exceeds 1024 instead of attempting to re-chunk #29
+7
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khaledsulayman
requested review from
alimaredia,
fabianofranz,
anastasds,
iamemilio,
alinaryan and
JustinXHale
as code owners
khaledsulayman
force-pushed
the
fix-rechunking
branch
from
fe5cdcb to
c25f46b
Compare
alimaredia
reviewed
Jun 11, 2025
khaledsulayman
force-pushed
the
fix-rechunking
branch
2 times, most recently
from
328e9ef to
c78d1f7
Compare
khaledsulayman
force-pushed
the
fix-rechunking
branch
from
c78d1f7 to
d408ab8
Compare
…hunk Signed-off-by: Khaled Sulayman <[email protected]>
khaledsulayman
force-pushed
the
fix-rechunking
branch
from
d408ab8 to
961dbd2
Compare
alimaredia
reviewed
Jun 16, 2025
| ) | ||
| for c in chunked_document_all_icl: | ||
| if get_token_count(c["document"], tokenizer) > 1024: | ||
| raise ValueError("Chunk exceeds token count of 1024") |
There was a problem hiding this comment.
Could we get the first X and last X tokens in the chunk printed out as well as all chunks that are too big into a list and all printed out at once. This way a users know where they need to trim down their chunks before moving forward.
It would look something like:
Chunk Size Errors:
Chunk "foo bar baz ... biz baz bar." exceeds max token count of 1024.
Chunk "foo2 bar2 baz2 ... biz2 baz2 bar2." exceeds max token count of 1024.
....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the sdg_hub code where this came from, there was a call to
chunk_document()that would be made if the token count of a particular chunk exceeded 1024.The
chunk_documentfunction uses the recursive text splitter to split chunks to certain token size thresholds, but realistically should not be needed anymore given our use of the hybrid chunker. This PR raises a more explicit error in the case that we do exceed 1024.