Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ARM and ACTARM. #317

Merged
merged 6 commits into from
Sep 28, 2024
Merged

Update ARM and ACTARM. #317

merged 6 commits into from
Sep 28, 2024

Conversation

qiliu1013
Copy link
Contributor

Pull Request

Fixes #315

@qiliu1013 qiliu1013 linked an issue Sep 28, 2024 that may be closed by this pull request
3 tasks
Copy link
Contributor

github-actions bot commented Sep 28, 2024


🎉 Thank you for your contribution! Before this PR can be accepted, we require that you all read and agree to our Contributor License Agreement.
You can digitally sign the CLA by posting a comment on this Pull Request in the format shown below. This agreement will apply to this PR as well as all future contributions on this repository.


I have read the CLA Document and I hereby sign the CLA


2 out of 3 committers have signed the CLA.
✅ (qiliu1013)[https://github.com/qiliu1013]
✅ (shajoezhu)[https://github.com/shajoezhu]
@Qi Liu
Qi Liu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Copy link
Contributor

github-actions bot commented Sep 28, 2024

Unit Tests Summary

  1 files    4 suites   31s ⏱️
 61 tests  61 ✅ 0 💤 0 ❌
127 runs  127 ✅ 0 💤 0 ❌

Results for commit 417e8ba.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Sep 28, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
row_values 💔 $8.85$ $+2.70$ $+21$ $-21$ $0$ $0$

Results for commit 5db84ee

♻️ This comment has been updated with latest results.

@qiliu1013
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@shajoezhu shajoezhu added the sme label Sep 28, 2024
R/radab.R Outdated Show resolved Hide resolved
@shajoezhu
Copy link
Contributor

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor

badge

Code Coverage Summary

Filename         Stmts    Miss  Cover    Missing
-------------  -------  ------  -------  -----------------------------------------
R/radab.R          290       1  99.66%   398
R/radae.R          198       3  98.48%   76, 95, 284
R/radaette.R       203       4  98.03%   50, 72, 78, 260
R/radcm.R          150       2  98.67%   51, 204
R/raddv.R           91       2  97.80%   54, 137
R/radeg.R          266       1  99.62%   366
R/radex.R          229       1  99.56%   320
R/radhy.R          136       1  99.26%   198
R/radlb.R          334       1  99.70%   426
R/radmh.R           93       2  97.85%   45, 134
R/radpc.R           85       1  98.82%   125
R/radpp.R           83       1  98.80%   153
R/radqlqc.R       1024       7  99.32%   331, 820, 1112-1116
R/radqs.R          118       1  99.15%   185
R/radrs.R          122       3  97.54%   47, 54, 183
R/radsaftte.R        1       0  100.00%
R/radsl.R          180       1  99.44%   260
R/radsub.R         140       2  98.57%   171, 235
R/radtr.R          124       0  100.00%
R/radtte.R         208       4  98.08%   52, 72, 84, 279
R/radvs.R          178       1  99.44%   251
R/utils.R          156      14  91.03%   59, 195, 204, 207, 244, 256, 260, 290-296
TOTAL             4409      53  98.80%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  -------
R/radab.R        +6       0  +0.01%
TOTAL            +6       0  +0.00%

Results for commit: 417e8ba

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@shajoezhu shajoezhu enabled auto-merge (squash) September 28, 2024 08:43
Copy link
Contributor

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks @qiliu1013

@shajoezhu shajoezhu merged commit 301c347 into main Sep 28, 2024
28 of 29 checks passed
@shajoezhu shajoezhu deleted the 315-refactor-adab branch September 28, 2024 08:43
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor ADAB
2 participants