Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support padding for the leaves of the merkle tree #647

Open
wants to merge 36 commits into
base: main
Choose a base branch
from
Open

Support padding for the leaves of the merkle tree #647

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
31cccae
Did some organization in test_hash_api and fixed some edge case that …
Koren-Brand Oct 21, 2024
304e0f2
basic test pass
mickeyasa Oct 27, 2024
126a25f
all tests pass without padding
mickeyasa Oct 27, 2024
8018c0d
basic test pass
mickeyasa Oct 27, 2024
c57d71f
Revert "basic test pass"
mickeyasa Oct 27, 2024
b1e2b56
basic tests pass
mickeyasa Oct 28, 2024
8cc8e20
Initial test for padding in merkle tree. currently crashes when tryin…
Koren-Brand Oct 29, 2024
50ee230
bug fix at proof allocation
mickeyasa Oct 30, 2024
904fc0e
output buffer overflow in hash (seems to launch hash twice)
Koren-Brand Oct 30, 2024
2d84a26
bug fix for the case of 17 hases at the last layer
mickeyasa Oct 30, 2024
628caf0
formating
mickeyasa Oct 30, 2024
3713911
Partial leaf test of zero padding has memory overflow when copying to…
Koren-Brand Oct 31, 2024
8c19873
bug fix T tHe padded vector
mickeyasa Nov 3, 2024
4870d28
Added interesting cases for zero padding and duplicated the zero padd…
Koren-Brand Nov 3, 2024
030b7af
format
mickeyasa Nov 5, 2024
c7acc78
input_default -> default_input
mickeyasa Nov 6, 2024
1cc58cc
Merge remote-tracking branch 'origin/main' into MTpaddingSupport
mickeyasa Nov 6, 2024
c861d20
assert changed
mickeyasa Nov 6, 2024
f0d6f04
spelling fix
mickeyasa Nov 6, 2024
bb2a244
format
mickeyasa Nov 6, 2024
3c6d0a6
Weird test with cuda and cpu MerkleTreeLarge - root doesn't match and…
Koren-Brand Nov 7, 2024
ad26b10
Prints now work (Decimal instead of hex)
Koren-Brand Nov 10, 2024
7c1eff7
Fixed stack-use-after-scope error (Accessing root after tree is delet…
Koren-Brand Nov 10, 2024
b76fda5
formatting
Koren-Brand Nov 10, 2024
029df1d
Fixed bug that caused poseidon merkle tree to fail on rust (And added…
Koren-Brand Nov 11, 2024
438ebb4
Bug fix in poseidon_tree test in test-hash-api (CPP) where field elem…
Koren-Brand Nov 12, 2024
2ba560e
formatting
Koren-Brand Nov 12, 2024
fa769a6
Fixed the documentation to match the actual function is_valid_tree
Koren-Brand Nov 12, 2024
57fd5f1
other PR changes
Koren-Brand Nov 12, 2024
a2925f7
fix device that was not defined in scope to s_reference_target in pad…
Koren-Brand Nov 12, 2024
1e4c19e
use smart pointers
mickeyasa Nov 12, 2024
bbda10c
format
mickeyasa Nov 12, 2024
b9a8d18
Standardized the Merkle tree test in test_hash_api.cpp to all use the…
Koren-Brand Nov 12, 2024
433ba9e
spelling
Koren-Brand Nov 12, 2024
ab7d7bf
Statistically possible valid wrong leaves during Merkle tree test has…
Koren-Brand Nov 13, 2024
d5fe54c
formatting
Koren-Brand Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions icicle/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,11 @@ endif()
# Print the selected build type
message(STATUS "Build type: ${CMAKE_BUILD_TYPE}")

# Prevent build if both SANITIZE and CUDA_BACKEND are enabled
if(SANITIZE AND CUDA_BACKEND)
message(FATAL_ERROR "Address sanitizer and Cuda cannot be enabled at the same time.")
endif()

# Find the ccache program
find_program(CCACHE_PROGRAM ccache)
# If ccache is found, use it as the compiler launcher
Expand Down Expand Up @@ -132,5 +137,4 @@ endif()

if (BUILD_TESTS)
add_subdirectory(tests)
endif()

endif()
Loading
Loading