Support padding for the leaves of the merkle tree #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…can cause the test to seg-fault Signed-off-by: Koren-Brand <[email protected]>
This reverts commit 8018c0d.
…g to generate a proof of the last (and only) leaf index Signed-off-by: Koren-Brand <[email protected]>
Signed-off-by: Koren-Brand <[email protected]>
… padded_leaves (during build, init_padded_leaves, line 441) Signed-off-by: Koren-Brand <[email protected]>
…ing test for last value padding Signed-off-by: Koren-Brand <[email protected]>
mickeyasa
commented
Nov 6, 2024
mickeyasa
force-pushed
the
MTpaddingSupport
branch
from
346d918
to
c861d20
Compare
… cuda always has zeros in some parts Signed-off-by: Koren-Brand <[email protected]>
Signed-off-by: Koren-Brand <[email protected]>
…ed) and some additional memory leaks in Merkle tree cpu backend as well as the hash tests Signed-off-by: Koren-Brand <[email protected]>
Signed-off-by: Koren-Brand <[email protected]>
… the same test to cpp test_hash_api) Signed-off-by: Koren-Brand <[email protected]>
…ents weren't randomized properly Signed-off-by: Koren-Brand <[email protected]>
Signed-off-by: Koren-Brand <[email protected]>
yshekel
reviewed
Nov 12, 2024
yshekel
reviewed
Nov 12, 2024
yshekel
reviewed
Nov 12, 2024
yshekel
reviewed
Nov 12, 2024
yshekel
reviewed
Nov 12, 2024
yshekel
reviewed
Nov 12, 2024
yshekel
reviewed
Nov 12, 2024
yshekel
reviewed
Nov 12, 2024
yshekel
reviewed
Nov 12, 2024
yshekel
reviewed
Nov 12, 2024
yshekel
reviewed
Nov 12, 2024
yshekel
reviewed
Nov 12, 2024
| ~CPUMerkleTreeBackend() | ||
| { | ||
| for (auto& pair : m_map_segment_id_2_inputs) { | ||
| delete pair.second; // Ensure all dynamically allocated memory is freed |
There was a problem hiding this comment.
modern C++ should avoid new/malloc+delete/free and use smart pointers anyway. This would avoid the leak and also works when exceptions are thrown.
There is usually no reason to use malloc/new
yshekel
reviewed
Nov 12, 2024
yshekel
reviewed
Nov 12, 2024
| m_map_segment_id_2_inputs.erase(completed_segment_id); | ||
| auto segment = m_map_segment_id_2_inputs.find(completed_segment_id); | ||
| if (segment != m_map_segment_id_2_inputs.end()) { | ||
| delete segment->second; |
There was a problem hiding this comment.
same comment here. With smart pointers you only need to erase
Signed-off-by: Koren-Brand <[email protected]>
Signed-off-by: Koren-Brand <[email protected]>
…ding tests Signed-off-by: Koren-Brand <[email protected]>
… same test_merkle_tree function Signed-off-by: Koren-Brand <[email protected]>
Signed-off-by: Koren-Brand <[email protected]>
… been addressed Signed-off-by: Koren-Brand <[email protected]>
Signed-off-by: Koren-Brand <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support padding for the leaves of the merkle tree